[BUG] "Run at Startup" set wrong path in Windows Registy

[fubaWoW]

Version Number

6.5.2

File

Portable (VolumeControl.exe)

Windows Version

Windows 11 22H2 Build 22624.2428

Actual Behaviour

The Run at Startup set a wrong or partially wrong path in the Windows Registry.

Actual Windows Registry if ```Run at Startup`` is enabled

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run]
"VolumeControl"="D:\\Settings\\Tools\\VolumeControl

Screenshot:

Expected Behaviour

But this Registry key should be set

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run]
"VolumeControl"="D:\\Settings\\Tools\\VolumeControl\\VolumeControl.exe"

Screenshot:

also you should set this

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run]
"VolumeControl"=hex:02,00,00,00,00,00,00,00,00,00,00,00

Screenshot:

Reproduction Steps

No response

Log

Log file does not help (again), but here:

HH:mm:ss:fff              === Log Initialized @ Sonntag, 12. November 2023 20:13:15 ===  { LogFilter: 0 (NONE) }
21:13:29:545  [TRACE]     Config property 'LogFilter' was modified.
21:13:29:545  [TRACE]     Saved Config (Caller: "HandlePropertyChanged")
21:13:32:748  [TRACE]     Config property 'RunAtStartup' was modified.
21:13:32:748  [TRACE]     Saved Config (Caller: "HandlePropertyChanged")
21:13:33:033  [TRACE]     Config property 'RunAtStartup' was modified.
21:13:33:033  [TRACE]     Saved Config (Caller: "HandlePropertyChanged")
21:14:32:936  [TRACE]     Config property 'RunAtStartup' was modified.
21:14:32:936  [TRACE]     Saved Config (Caller: "HandlePropertyChanged")
21:14:33:468  [TRACE]     Config property 'RunAtStartup' was modified.
21:14:33:468  [TRACE]     Saved Config (Caller: "HandlePropertyChanged")

[radj307]

On it.

[radj307]

Regarding setting a value in HKCU\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run, it probably isn't necessary. It's used by the Task Manager to enable/disable run at startup entries, and isn't generally managed by applications. If Volume Control needed to force itself to run at startup regardless of whether the user disabled it through the task manager, that's the key to use, but it doesn't need to do that.

Either way, I'll build the functionality to do this in, but the actual implementation probably won't use it.

[radj307]

Should be fixed in 5ed7671

Currently building a test build for you to make sure it works on your end.

[radj307]

Here is a test build with the fix, and download instructions should you need them.

[fubaWoW]

The Path is now correct and works but (for me) only if StartupApproved is set.

Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run]
"VolumeControl"=hex:02,00,00,00,00,00,00,00,00,00,00,00

As you can see in the screenshot below, many 3rd party apps added themself to StartupApproved, so this is maybe needed in Windows 11?

[radj307]

Usually the Task Manager Windows adds that on its own (StartupApproved was set automatically in my case), but if that didn't work on your system then there is a good argument for setting that explicitly.

[radj307]

As of f9ad6a8 a value in StartupApproved\Run is created explicitly.

[radj307]

Now available in v6.6.1

[fubaWoW]

Thank you, i will test it later 😎