Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 5.2.1 - GUI issues #32

Closed
bovirus opened this issue Aug 6, 2022 · 9 comments
Closed

[BUG] 5.2.1 - GUI issues #32

bovirus opened this issue Aug 6, 2022 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@bovirus
Copy link
Contributor

bovirus commented Aug 6, 2022

@radj307

Using Italian language I found some issues.

Please check screenshot

image

Some strings are untranslated.
Move from main settings json file to language json file.

The width of "Maiusc" coulmn is too small.
Please enlarge main window width and increase space for "Maiusc" column.

@bovirus
Copy link
Contributor Author

bovirus commented Aug 6, 2022

image

The width of "Seleziona" button is too small.
Please enlarge main window width and increase space for "Seleziona" button.

@bovirus
Copy link
Contributor Author

bovirus commented Aug 6, 2022

image

"On volume change" seems not translated (but is translated in language file).

Move "Update" option left on the elft and right ion the right.
Then you can increase space for central option about update.

@bovirus
Copy link
Contributor Author

bovirus commented Aug 6, 2022

image

In system control tray there are three strings not localzied and not included in language file.

I sugegst to change

"Show" in "Open Volume Control mai window"
"Bring to front" in "Bring Volume Control to front"
"Close" to "Close Volume ControL".

Or make a small windo with an header "Volume Control" and the below the command "Show", "Bring to front", "Close".
The will eb clear that the command are relative to Voluem Control.

For italian the translation is

"Show" .-> "Apri finestra principale Volume Control"
"Bring to front" -> "Porrta Volume Control in primo piano"
"Close" -> "Chiudi Volume Control"

@bovirus
Copy link
Contributor Author

bovirus commented Aug 6, 2022

About tab.

I beilieve that could be inetersting to have an "About" tab that show information about program name and version and link about website and support link.

radj307 added a commit that referenced this issue Aug 6, 2022
@radj307
Copy link
Owner

radj307 commented Aug 6, 2022

About tab.

I beilieve that could be inetersting to have an "About" tab that show information about program name and version and link about website and support link.

I moved this to its own issue

@radj307
Copy link
Owner

radj307 commented Aug 6, 2022

I increased the size of the margins in for the controls in the update section, and fixed a bug where the program was looking for a key named OnVolumeChanged instead of OnVolumeChange:

They'll both be fixed in 5.2.2


Translation support for the NotifyIcon options will be added in 5.2.2

I sugegst to change

"Show" in "Open Volume Control mai window"
"Bring to front" in "Bring Volume Control to front"
"Close" to "Close Volume ControL".

I'm hesitant to make each of the options that verbose, as it can use up a lot of space very quickly; I can, however, add a header with the program name & version number to the top to provide some context


I increased the amount of padding in the select buttons, which will be included in 5.2.2:

image

I also increased the margins in the Settings -> Update section, which will also be included in 5.2.2


I set the Alt/Ctrl/Shift/Win column sizes to Auto, which is also going to be included in 5.2.2:

image

@radj307
Copy link
Owner

radj307 commented Aug 6, 2022

Hotkey name & action identifier translations will take some more time to implement, since it has to be compatible with the addons system.
I'll most likely be implementing hotkey/action translations in separate files, that way addon developers can distribute their own translations along with the addon dlls.

@radj307 radj307 self-assigned this Aug 6, 2022
@radj307 radj307 added the bug Something isn't working label Aug 6, 2022
@bovirus bovirus changed the title [BUG] GUI issues [BUG] 5.2.1 - GUI issues Aug 6, 2022
@bovirus
Copy link
Contributor Author

bovirus commented Aug 6, 2022

@radj307

Update italian language.
Please check and merge and release new application version.

If you can please check also this request

#36

@radj307
Copy link
Owner

radj307 commented Aug 6, 2022

Please limit issue reports to the actual issue being reported.

GUI bugs have been fixed in 5.2.2

@radj307 radj307 closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants