Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Fix possible misuse of reflect.SliceHeader vet error when go 1.16.6 #139 #141

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

andyli029
Copy link
Contributor

@andyli029 andyli029 commented Jul 14, 2021

[summary]
Fix possible misuse of reflect.SliceHeader vet error when go 1.16.6

[test case]
utils/unsafe_test.go

[patch codecov]
utils/unsafe.go 100%

What type of PR is this?

Which issue(s) this PR fixes?

Fixes #139

What this PR does?

Summary:

Special notes for your reviewer?

….16.6 radondb#139

[summary]
fix go vet failed when go 1.16.6

[test case]
utils/unsafe_test.go

[patch codecov]
utils/unsafe.go 100%
@andyli029 andyli029 marked this pull request as draft July 14, 2021 07:06
@andyli029 andyli029 requested review from zhyass and removed request for zhyass July 14, 2021 07:06
@andyli029 andyli029 marked this pull request as ready for review July 14, 2021 07:06
@andyli029 andyli029 changed the title utils: fix go vet failed when go 1.16.6 #139 utils: Fix possible misuse of reflect.SliceHeader vet error when go 1.16.6 #139 Jul 14, 2021
@andyli029 andyli029 self-assigned this Jul 14, 2021
@andyli029 andyli029 added the bug Something isn't working label Jul 14, 2021
@andyli029 andyli029 added this to the v1.3.0 milestone Jul 14, 2021
@zhyass
Copy link
Contributor

zhyass commented Jul 15, 2021

LGTM

@andyli029 andyli029 merged commit b1ffd45 into radondb:main Jul 16, 2021
zhl003 pushed a commit to zhl003/radondb-mysql-kubernetes that referenced this pull request Aug 17, 2022
utils: Fix possible misuse of reflect.SliceHeader vet error when go 1.16.6 radondb#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make failed when go 1.16.6
3 participants