forked from niko/em_mysql2_connection_pool
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
16 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5773322
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started implementing a global errback.
Also I'm thinking about calling a predefined errback that just puts the error if no global and no local errback is defined. That should make finding errors easier, especially for ppl not used to the whole callback/errback thing. What do you think?
5773322
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit leery about things that puts, but if it only does that without any user-defined error handler at all, that seems reasonable.
5773322
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right with your opinion to puts… I just thought: Not handling errors at all is mistake and users doing this could use the help of some additional puts if/when errors actually occur. Perhaps I'll just add it and see if people complain. :)
5773322
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me.