Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Machine from algorithms #7

Closed
radumg opened this issue Feb 8, 2018 · 2 comments · Fixed by #11
Closed

Decouple Machine from algorithms #7

radumg opened this issue Feb 8, 2018 · 2 comments · Fixed by #11
Assignees
@radumg
Labels
enhancement
Projects
1.0 abstracted ML machines + algos
Milestone
1.0 - Abstracted ...

Comments

@radumg
Copy link
Owner

radumg commented Feb 8, 2018

This enhancement would decouple a Machine from any particular algorithm, instead allowing us to specify the algorithm as an input.

Requires
#2 to be completed
abstracting Machine to use Accord.NET interfaces
@radumg radumg created this issue from a note in 1.0 abstracted ML machines + algos (To Do) Feb 8, 2018
@radumg radumg mentioned this issue Feb 8, 2018
Open
3 tasks
@radumg radumg added this to the 1.0 milestone Feb 8, 2018
@radumg radumg mentioned this issue Feb 8, 2018
Open
4 tasks
@radumg radumg self-assigned this Feb 8, 2018
@radumg radumg moved this from To Do to In progress in 1.0 abstracted ML machines + algos Feb 24, 2018
@radumg radumg moved this from In progress to To Do in 1.0 abstracted ML machines + algos Feb 24, 2018
@radumg radumg moved this from To Do to In progress in 1.0 abstracted ML machines + algos Feb 24, 2018
@radumg radumg mentioned this issue Feb 24, 2018
Merged
@radumg
Copy link
Owner Author

radumg commented Feb 25, 2018

Turns out Accord.NET interfaces are not complete and the different algorithms don't implement the same interfaces - or in many cases any at all.

Will resort to wrappers that implement a common interface IAlgorithm instead,

radumg added a commit that referenced this issue Feb 25, 2018
@radumg
added IAlgorithm
acfc26d 
this is an abstraction layer to enable #7
@radumg
Copy link
Owner Author

radumg commented Feb 25, 2018 •
edited
Loading

fixed in PR #11

@radumg radumg closed this as completed Feb 25, 2018
1.0 abstracted ML machines + algos automation moved this from In progress to Done Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radumg radumg

Labels
enhancement
Projects
1.0 abstracted ML machines + algos
  
Done
Milestone
1.0 - Abstracted Machine + algos
Development

Successfully merging a pull request may close this issue.

1.0 interfaces radumg/DynAI
1 participant
@radumg