1.0 interfaces #11
Merged
1.0 interfaces #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added filepath as parameter, so methods can be static - adjusted return types for usability - updated MachineBase
- added metadata fields to IMachine - updated MachineBase - added public comments
- added constructor for RegressionMachine - added algorith Type as input - likely to not work yet though 😱
- made MachineBase a non-abstract class to support JSON deserialisation - added to/from JSON file support fixes #4
- Dynamo doesn't like types directly and the `Type` node returns a string, so let's accept objects and get their types instead of types directly - added simple constructor of RegressionMachine DYN file
- added DynamoVisualProgramming NuGet packages to enable this
- the Learn & Predict methods wouldn't be static anyway, so this duplicates the inputs to the nodes - removed JSON IO from interface - adjusted MachineBase to suit
- renamed Learned to Trained - changed Algorithm member to `object` not Type
|
started on #7 but not currently working |
this is an abstraction layer to enable #7
- updated IMachine to IAlgorithm - added new properties that wrap the algorithm's properties
implements IAlgorithm, so can be used in IMachines
- comment out Regression algorithms list - delete old JSON files - update DYN tests
- update MachineBase to use IAlgorithm interface & IMachine changes - also get rid of RegressionMachine
|
Interfaces and everything seems to work fine now, except for bug #12 |
This was referenced Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2
fixes #4
fixes #7