De-duplicate comand parsing code #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thanks, I can't see why "@@ foo" should not be in parse_input too. I'll investigate a bit more and make that change too. |
pjbroad
added a commit
that referenced
this pull request
Mar 2, 2013
De-duplicate comand parsing code
|
Looks like that code is never reached anyway unless we have lost the input widget. The common parse_input() function is used in the root_key_to_input_field() call at the top of the function. The additional check for "@@" just switches your default channel to the one specified then sends the text. IMHO, I'd rather the default channel was left as it was if I'm using "@@". Otherwise, I'd just switch default channels and use "@". I'm thinking to just remove that code.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some duplicated code and uses only parse_input() to parse the command input.
Note: not sure if "@@ foo" is meant to be supported in all windows so left the code checking for that where it was in gamewin.c.