-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance mode #3
Conversation
…s into instance_mode Conflicts: elconfig.c
Hi Post it in the programming forum too pls. On 12/19/2011 4:28, Karol wrote:
|
Made new thread in the programming forum: http://www.eternal-lands.com/forum/index.php?showtopic=56372 |
There's a minor bug with the banner context menu, the disable option should be 11 not 10 due to the separation bar. It would be much better if we could avoid a el.cfg version change, How about combining the banner values into a single word and using bit positions. Just like the misc options word. The then unused words can me kept for future additions. Perhaps the instance tab should not be the last in the row, I think Roja wanted trouble shooting there. How about moving the tab to be next to the hud tab? |
Fixed (I hope so ;)) issues pointed by pjbroad. Still not sure about el.cfg version thingie. I modified only options in init.h/init.c. Is that enough or should I look somewhere else to modify also settings i added only to elconfig.c (they're saved automagically and I have no idea where/how)? |
…n changed back to original, banner options as a single word
To keep compatibility with the old el.cfg you have to keep the order and number of bytes the same. It's a binary file :( So you need to add a couple of unused ints to the init.h file in the correct place: diff --git a/init.h b/init.h + int unsed_01;
The elconfig.c options are saved in the el.ini file which is a text file and there's no issue with compatibility. Like you said, it all automatically done. Also, it appears that in non-instance mode, the banner background size is set the same for all actors so too big for some. |
One more thing, you have removed the code that ensured there was a banner context menu region to click on even if all the banner options are disabled. I suggest you restore that bit of code. |
Ok, I moved instance banners options to the HUD tab, as Roja suggested on forum. Going to fix other issues ;). |
@@ -800,6 +800,7 @@ struct xml_struct | |||
ttab_camera[15], | |||
ttab_troubleshoot[15], | |||
ttab_font[10], | |||
ttab_instance[15], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this now:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed ;)
…om elconfig window
OK looks like i fixed background width in non instance mode, also fixed context menu issue when our banner is not visible. There is one more issue with background - when you turn on mana bar/number and turn off names. Working on it now. |
OK I hope everything is fine now ;). |
Great work:) |
I implemented something requested here:
http://www.eternal-lands.com/forum/index.php?showtopic=56252
however there are more answers in feature request thread than in my thread (http://www.eternal-lands.com/forum/index.php?showtopic=56274) so no idea if it should/can be included in this form.