Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: dts: rk3588: swap cursor and display plane #104

Merged
merged 1 commit into from
Apr 26, 2023
Merged

arm64: dts: rk3588: swap cursor and display plane #104

merged 1 commit into from
Apr 26, 2023

Conversation

RadxaYuntian
Copy link
Member

This property is causing mouse cursor becoming hidden on ROCK 5A & 5B.

Disable it for CM3 just in case.

Fixes Redmine 3021, Rockchip 408946.

@RadxaYuntian
Copy link
Member Author

Waiting for He Rui's confirmation.

@RadxaStephen
Copy link
Member

RadxaStephen commented Apr 21, 2023

@RadxaYuntian One pr related to cursor. #50

@RadxaYuntian
Copy link
Member Author

Cursor issue was reported in this thread.

@RadxaYuntian RadxaYuntian marked this pull request as draft April 21, 2023 04:01
Signed-off-by: ZHANG Yuntian <yt@radxa.com>
@RadxaYuntian RadxaYuntian changed the title arm64: dts: remove cursor-win-id arm64: dts: rk3588: swap cursor and display plane Apr 26, 2023
@RadxaYuntian RadxaYuntian marked this pull request as ready for review April 26, 2023 08:19
@RadxaYuntian
Copy link
Member Author

With this change the cursor seems to be stable.

@RadxaStephen
Copy link
Member

Great.

@RadxaStephen RadxaStephen merged commit fd59484 into radxa:linux-5.10-gen-rkr3.4 Apr 26, 2023
Scirese pushed a commit to Scirese/radxa-kernel that referenced this pull request Jun 29, 2023
Signed-off-by: ZHANG Yuntian <yt@radxa.com>
RadxaStephen pushed a commit that referenced this pull request Jul 3, 2023
Signed-off-by: ZHANG Yuntian <yt@radxa.com>
DsoTsin pushed a commit to Tsinworks/kernel-radxa-horizon that referenced this pull request Aug 1, 2023
Signed-off-by: ZHANG Yuntian <yt@radxa.com>
@amazingfate
Copy link

primary plane is changed to ROCKCHIP_VOP2_CLUSTER0, but cluster plane doesn't support gstreamer's kmssink. What's the root cause of cursor disappear?

@RadxaYuntian
Copy link
Member Author

After comparing with previous good version we found the issue was introduced in #50. Rockchip suggested to us to use esmart for cursor-win-id for this specific issue.

@amazingfate
Copy link

With the current devicetree I can use this pipeline to use kmssink:

gst-launch-1.0 -e videotestsrc ! video/x-raw,format=NV12,width=1920,height=1080,framerate=60/1 ! kmssink plane-id=71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants