Skip to content

Commit

Permalink
Check scanner error
Browse files Browse the repository at this point in the history
  • Loading branch information
rafaeljusto committed Oct 29, 2015
1 parent be1b62b commit e9ea8fb
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
6 changes: 6 additions & 0 deletions cmd/gddofork/gddofork.go
Expand Up @@ -106,11 +106,17 @@ func readFromFile(file string) ([]database.Package, error) {

var pkgs []database.Package
scanner := bufio.NewScanner(f)

for scanner.Scan() {
pkgs = append(pkgs, database.Package{
Path: scanner.Text(),
})
}

if err := scanner.Err(); err != nil {
return nil, fmt.Errorf("error reading file “%s”: %s\n", file, err)
}

return pkgs, nil
}

Expand Down
6 changes: 6 additions & 0 deletions cmd/gddoscore/gddoscore.go
Expand Up @@ -93,9 +93,15 @@ func readFromFile(file string) (map[string]bool, error) {

pkgs := make(map[string]bool)
scanner := bufio.NewScanner(f)

for scanner.Scan() {
pkgs[scanner.Text()] = true
}

if err := scanner.Err(); err != nil {
return nil, fmt.Errorf("error reading file “%s”: %s\n", file, err)
}

return pkgs, nil
}

Expand Down

0 comments on commit e9ea8fb

Please sign in to comment.