-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove saving window scroll position during scrolling #47
Comments
Now I'm binding the scroll with gsettings, could you test if this solve the issue? Otherwise, I'm going to implement a more performant approach. |
Nothing has changed. The program behavior is the same. |
Right. I will implement some logic to improve this. |
I have implemented smart scroll position saving. Could you test if still lags for you? |
There is no lags anymore. However, saving may not occur if less than a second has elapsed between changing the scroll and closing the window. You can set a smaller timeout, but why not just do the save when closing the window? The same approach can be applied to saving volume scrolls' position, which will drastically reduce the number of I/O operations. |
That was my first idea, but constant electrical cuts where I live made me implement it in this way. However, I agree about saving on close would be better. I will try to figure out a better approach, otherwise I will implement the save when closing the window. |
save sounds settings (custom audios / volume level) on window close related to #47
Scrolling is laggy as the Blanket writes the window scroll position to disk directly during scrolling. It also makes my HDD make noise (this is what prompted me to write an issue in the first place).
The text was updated successfully, but these errors were encountered: