Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove saving window scroll position during scrolling #47

Closed
RedGradient opened this issue Sep 17, 2020 · 6 comments
Closed

Remove saving window scroll position during scrolling #47

RedGradient opened this issue Sep 17, 2020 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@RedGradient
Copy link

Scrolling is laggy as the Blanket writes the window scroll position to disk directly during scrolling. It also makes my HDD make noise (this is what prompted me to write an issue in the first place).

@RedGradient RedGradient changed the title Remove saving window scroll position during scrolling. Remove saving window scroll position during scrolling Sep 17, 2020
@rafaelmardojai
Copy link
Owner

Now I'm binding the scroll with gsettings, could you test if this solve the issue?

Otherwise, I'm going to implement a more performant approach.

@RedGradient
Copy link
Author

Nothing has changed. The program behavior is the same.
Version: 0.3.1.r6.g2d80889

@rafaelmardojai
Copy link
Owner

Right. I will implement some logic to improve this.

rafaelmardojai added a commit that referenced this issue Sep 23, 2020
@rafaelmardojai
Copy link
Owner

rafaelmardojai commented Sep 23, 2020

I have implemented smart scroll position saving. Could you test if still lags for you?

@RedGradient
Copy link
Author

There is no lags anymore. However, saving may not occur if less than a second has elapsed between changing the scroll and closing the window. You can set a smaller timeout, but why not just do the save when closing the window? The same approach can be applied to saving volume scrolls' position, which will drastically reduce the number of I/O operations.

@rafaelmardojai
Copy link
Owner

That was my first idea, but constant electrical cuts where I live made me implement it in this way.

However, I agree about saving on close would be better. I will try to figure out a better approach, otherwise I will implement the save when closing the window.

rafaelmardojai added a commit that referenced this issue Dec 1, 2020
@rafaelmardojai rafaelmardojai added this to the 0.4.0 milestone Dec 27, 2020
@rafaelmardojai rafaelmardojai added the enhancement New feature or request label Dec 27, 2020
rafaelmardojai added a commit that referenced this issue Dec 27, 2020
save sounds settings (custom audios / volume level) on window close
related to #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants