Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global state #1141

Merged
merged 91 commits into from
Dec 20, 2018
Merged

Remove global state #1141

merged 91 commits into from
Dec 20, 2018

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Nov 28, 2018 •
edited
Loading

This PR removes global state (eg. misago.core.threadstore) from Misago.

Fixes #1140

TODO

@rafalp rafalp added area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience labels Nov 28, 2018
@rafalp rafalp added this to the 0.20.0 milestone Nov 28, 2018
@rafalp rafalp self-assigned this Nov 28, 2018
@rafalp
Revert old cache versioning migrations to make build pass
8762f23
@rafalp
Cleanup migration
f96aea9
@rafalp
Move user online utils to take request instead of viewer
b950fc4
@rafalp
Remove global state from bans
cdea0c5
@rafalp
Remove bans cache versioning from old cache versioning feature
e44ca3f
@rafalp
Merge pull request #1143 from rafalp/remove-global-state-from-users-bans
44b648e 
Remove global state from users bans
@rafalp
Add non-global acl implementation and testing utils
58cbc43
@rafalp
Include user staff and superuser status flags in user_acl
8ef7c58
@rafalp
Make tests pass for misago.users
1e2df6e
@rafalp
Improve get_user_status tests
0354f43
@rafalp
Improve patch_user_acl testing utility and get_user_status tests
8e63ac7
@rafalp
Improve test util to work as decorator or context processor
55156a8
@rafalp
Update misago.users tests to use new testing utilities
263dff9
@rafalp
Update readtracker to use user_acl
cc47a3b
@rafalp
Remove cache and global state dependency from readtracker tests
aebcf97
@rafalp
Fix tests for thread view
d2be86e
@rafalp
Merge pull request #1145 from rafalp/remove-global-state-from-acl
7f1ee27 
Remove global state from ACL
@rafalp
Early groundwork for new database settings proxy
4d63810
@rafalp
Add override_dynamic_settings testing utility
008a41a
@rafalp
Add tests for getting/overriding dynamic setting value
e853de8
@rafalp
Add tests for dynamic settings loading, improve test assertions in mi…
8505aef 
…sago.cache
@rafalp
Rename tests suite, add tests for other use-cases
8c40166
@rafalp
Add tests for dynamic settings middleware
e7bb86b
@rafalp
Move context processor to request.settings, rename it to conf.
daf2130
@rafalp
Add dynamic settings to email context
53e2e1d
@rafalp
Small code cleanups before removing global state from create_user
ffe17db
@rafalp
Small cleanup for user model/manager, add util for setting up new use…
2a70559 
…r account after its creation
@rafalp
Update misago.users.tests to crash less
facfb05
@rafalp
Fix misago.users tests
6359d07
@rafalp
Fix misago.core tests
09e578b
@rafalp
Fix misago.threads tests
0a7ebe4
@rafalp
Add StaticSettings object
7c1f51e
@rafalp
Finalize misago.conf module
c7ff046
@rafalp
Remove special check for dynamic setting access from StaticSettings
259821c
@rafalp
Remove db_settings usage from misago.users
6613de5
@rafalp
Remove global db_settings form codebase
9d18591
@rafalp
Revert change in user profile
57a0194
@rafalp
Merge pull request #1144 from rafalp/remove-global-state-from-db-sett…
9ecf2bd 
…ings

Remove global state from dynamic settings
@rafalp
Make misago.core.threadstore methods raise NotImplementedError on use
add80c2
@rafalp
Remove threadstate middleware and MisagoTestCase
0207c78
@rafalp
Make tests pass
1e22a23
@rafalp
Remove misago.core.threadstore
172285e
@rafalp
Remove unused get_cache_key from dynamicsettings
4477bb0
@rafalp
Merge pull request #1149 from rafalp/remove-global-state-threadstore
fa50746 
Remove misago.core.threadstore
@rafalp rafalp merged commit 948eb54 into master Dec 20, 2018
@rafalp rafalp deleted the remove-global-state branch December 20, 2018 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafalp rafalp

Labels
area: backend This issue involves Python, Django or dependency (eg. database) enhancement Improvement to existing feature or dev experience
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rafalp