refactor(tools): rename class to hide element impress-org#2875

raftaar1191 · Apr 1, 2018 · 310318e · 310318e
1 parent b766f06
commit 310318e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/assets/src/css/admin/forms.scss b/assets/src/css/admin/forms.scss
@@ -29,6 +29,10 @@ Forms CPT
 	display: none;
 }
 
+.give-visibility-hidden {
+	visibility: hidden;
+}
+
 /* Donation Levels Repeating Field */
 #_give_donation_levels_repeat > .cmb-repeatable-grouping .cmb-field-list > .cmb-row .cmb2-radio-list label {
 	font-size: 12px;

diff --git a/assets/src/js/admin/admin-settings.js b/assets/src/js/admin/admin-settings.js
@@ -156,7 +156,7 @@ jQuery(document).ready(function ($) {
 	 */
 	$( '.give-export_donations #give-export_donations-form #give_form_for_csv_export' ).chosen().change( function () {
 
-		$( '.give-export-donations-hide' ).addClass( 'give-hidden' );
+		$( '.give-export-donations-hide' ).addClass( 'give-visibility-hidden' );
 
 		var give_form_id;
 
@@ -179,6 +179,7 @@ jQuery(document).ready(function ($) {
 			success: function ( response ) {
 
 				if ( response ) {
+
 					output_give_donations_fields( response );
 
 				} else {
@@ -196,6 +197,8 @@ jQuery(document).ready(function ($) {
 	 */
 	function output_give_donations_fields( response ) {
 
+
+
 		/**
 		 * FFM Fields
 		 */
@@ -204,9 +207,11 @@ jQuery(document).ready(function ($) {
 		) ? response.ffm_fields : '';
 		var ffm_field_list = $( '.give-export-donations-ffm ul' );
 
+
+
 		if ( ffm_fields ) {
 
-			ffm_field_list.closest( 'tr' ).removeClass( 'give-hidden' );
+			ffm_field_list.closest( 'tr' ).removeClass( 'give-visibility-hidden' );
 
 			// Loop through FFM fields & output
 			$( ffm_fields ).each( function ( index, value ) {
@@ -251,7 +256,7 @@ jQuery(document).ready(function ($) {
 		) ? response.standard_fields : '';
 		var standard_field_list = $( '.give-export-donations-standard-fields ul' );
 		if ( standard_fields.length > 0 ) {
-			standard_field_list.closest( 'tr' ).removeClass( 'give-hidden' );
+			standard_field_list.closest( 'tr' ).removeClass( 'give-visibility-hidden' );
 			// Loop through STANDARD fields & output
 			$( standard_fields ).each( function ( index, value ) {
 				standard_field_list.append( '<li><label for="give-give-donations-standard-field-' + value + '"><input type="checkbox" name="give_give_donations_export_option[' + value + ']" id="give-give-donations-standard-field-' + value + '">' + value + '</label> </li>' );
@@ -265,7 +270,7 @@ jQuery(document).ready(function ($) {
 		var hidden_field_list = $( '.give-export-donations-hidden-fields ul' );
 
 		if ( hidden_fields ) {
-			hidden_field_list.closest( 'tr' ).removeClass( 'give-hidden' );
+			hidden_field_list.closest( 'tr' ).removeClass( 'give-visibility-hidden' );
 
 			// Loop through HIDDEN fields & output.
 			$( hidden_fields ).each( function ( index, value ) {

diff --git a/includes/admin/tools/export/class-give-export-donations.php b/includes/admin/tools/export/class-give-export-donations.php
@@ -320,7 +320,7 @@ public function html() {
 						</td>
 					</tr>
 
-					<tr valign="top" class="give-hidden give-export-donations-hide give-export-donations-ffm">
+					<tr valign="top" class="give-visibility-hidden give-export-donations-hide give-export-donations-ffm">
 						<th scope="row" class="titledesc">
 							<label for="json"><?php _e( 'Form Field Manager Fields:', 'give' ); ?></label>
 						</th>
@@ -334,7 +334,7 @@ public function html() {
 						</td>
 					</tr>
 
-					<tr valign="top" class="give-hidden give-export-donations-hide give-export-donations-standard-fields">
+					<tr valign="top" class="give-visibility-hidden give-export-donations-hide give-export-donations-standard-fields">
 						<th scope="row" class="titledesc">
 							<label for="json"><?php _e( 'Custom Field Columns:', 'give' ); ?></label>
 						</th>
@@ -348,7 +348,7 @@ public function html() {
 						</td>
 					</tr>
 
-					<tr valign="top" class="give-hidden give-export-donations-hide give-export-donations-hidden-fields">
+					<tr valign="top" class="give-visibility-hidden give-export-donations-hide give-export-donations-hidden-fields">
 						<th scope="row" class="titledesc">
 							<label for="json"><?php _e( 'Hidden Custom Field Columns:', 'give' ); ?></label>
 						</th>