-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cooperative settlement #1474
Cooperative settlement #1474
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1474 +/- ##
==========================================
+ Coverage 80.66% 80.81% +0.15%
==========================================
Files 22 22
Lines 1562 1564 +2
Branches 190 190
==========================================
+ Hits 1260 1264 +4
+ Misses 255 253 -2
Partials 47 47
Continue to review full report at Codecov.
|
1a1cfb5
to
8ea8c7d
Compare
f3ceef8
to
fa40dc1
Compare
327969c
to
7bdb530
Compare
9a28b87
to
7ba6598
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice to finally have a coop settle after such a long time!
This removes a bit of duplication.
82917c5
to
fcf83de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no solidity expert, but this looks good to me. It'd be good to have someone else more into solidity itself to review it though. I like the approach to leverage the double-withdraw signed structures, but we really need to optimise those gas usages
What this PR does
Implement cooperative settle (#1383)
Tasks
test_cooperative_settle_channel_event
)Why I'm making this PR
What's tricky about this PR (if any)
Any reviewer can check these:
make compile_contracts
and add the resultingraiden_contracts/data/contracts.json
in the PR.[skip ci]
in the commit message so Travis does not waste time.[skip ci]
and let Travis check the hash of the source.solidityFunction
_solidity_argument
solidity_variable
python_variable
PYTHON_CONSTANT
etherscan_verify.py
runs on the new contract.gas.json
.require()
orassert()
require()
doesn't require these steps.pytest.raises(TransactionFailed, match="error message"):
And before "merge" all checkboxes have to be checked. If you find redundant points, remove them.