Declare raiden-contracts to be typed via PEP561 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When other packages import raiden-contracts, the type signatures will not be used by mypy unless the package declares itself as properly types. This can be done via PEP561: https://mypy.readthedocs.io/en/latest/installed_packages.html#using-pep-561-compatible-packages-with-mypy Adding this will improve type checking quality in raiden-services (and potential other packages) whenever imports from raiden-contracts are used.
karlb
added a commit
to karlb/raiden-services
that referenced
this pull request
Apr 2, 2019
When raiden-network/raiden-contracts#813 gets merged we need this changes to avoid mypy errors.
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 20 20
Lines 1240 1240
Branches 129 129
=======================================
Hits 1027 1027
Misses 182 182
Partials 31 31
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 20 20
Lines 1240 1240
Branches 129 129
=======================================
Hits 1027 1027
Misses 182 182
Partials 31 31
Continue to review full report at Codecov.
|
palango
pushed a commit
to raiden-network/raiden-services
that referenced
this pull request
Apr 3, 2019
When raiden-network/raiden-contracts#813 gets merged we need this changes to avoid mypy errors.
This was referenced Apr 4, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When other packages import raiden-contracts, the type signatures will
not be used by mypy unless the package declares itself as properly
types. This can be done via PEP561:
https://mypy.readthedocs.io/en/latest/installed_packages.html#using-pep-561-compatible-packages-with-mypy
Adding this will improve type checking quality in raiden-services (and
potential other packages) whenever imports from raiden-contracts are
used.