Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure Raiden Network Smart Contracts Specification has the correct information, data fields and tables #253

Closed
pirapira opened this issue Sep 3, 2019 · 3 comments
Closed

Make sure Raiden Network Smart Contracts Specification has the correct information, data fields and tables #253

pirapira opened this issue Sep 3, 2019 · 3 comments
Assignees
@pirapira

Comments

@pirapira
Copy link
Contributor

pirapira commented Sep 3, 2019 •
edited

This issue keeps track of updating the spec for the current version of Raiden Network Smart Contracts.
This is a part of #252.

There have been several ABI breaking changes recently. I first make a list of those breaking changes and see if each change is reflected in the spec.
@pirapira pirapira self-assigned this Sep 3, 2019
@Dominik1999 Dominik1999 mentioned this issue Sep 3, 2019
Closed
21 tasks
@pirapira
Copy link
Contributor Author

pirapira commented Sep 3, 2019 •
edited

Unreleased

0.31.0 - 2019-08-20

  • #1163 MonitoringService.monitor() no longer works for service providers that are not registered in ServiceRegistry
  • #1177 When ServiceRegistry is deprecated, deposits can be immediately be withdrawn.

0.30.0 - 2019-08-15

0.29.1 - 2019-08-13

  • #1153 Upgrade web3.py and other dependencies

0.29.0 - 2019-07-26

  • #1143 Add ServiceRegistry.hasValidRegistration() function that returns whether a given address has a valid registration.

0.28.0 - 2019-07-26

  • #1140 ServiceRegistry exposes the list of addresses that have made deposits

0.27.0 - 2019-07-23

0.26.0 - 2019-07-11

0.25.1 - 2019-07-03

  • #1101 Add more gas measurements about CustomToken calls

0.25.0 - 2019-07-03

  • #1103 Add expiration_block argument to TokenNetwork.setTotalWithdraw(). Add expiration_block to setTotalWithdraw() args #266
  • #1099 Remove raiden_contracts.constants.GAS_REQUIRED_FOR* constants. Use instead raiden_contracts.contract_manager.gas_measurements().
  • #1079 Measure gas consumption of CustomToken.mint()
  • #1050 MonitoringService.claimReward() returns a boolean as the signature says

0.24.0 - 2019-06-19

  • #1023 Remove contract_version varible from the contracts
  • #1070 Type-annotate ChainIDs

0.23.0 - 2019-06-07

  • #1013 Remove EndpointRegistry contract (being done in Remove EndpointRegistry #267)
  • #1024 When OneToN checks the signature of an IOU, it considers MessageTypeId.IOU
  • #1062 Stopped using Merkle trees; instead the concatenation of all submitted locks is hashed
  • #1043 This Changelog is supposed to appear in the package

0.22.0 - 2019-06-03

  • #1034 Add gas.json in the package so gas_measurements(contracts_version) works.
  • #1025 MonitoringService.monitor() takes a signature that takes in the message ID.

0.21.0 - 2019-05-28

  • #1027 Add gas_measurements(contracts_version) that shows the gas measurements as a dictionary.
  • #988 Unlock-related functions' and events' arguments are renamed into sender and receiver Rename unlock participants #268

0.20.0 - 2019-05-17

0.19.1 - 2019-05-14

  • #973 Stop forcing a development-time dependency during the usual installation

0.19.0 - 2019-05-09

  • #909 MonitoringService prioritizes services
  • #853 add chain_id in the IOU claims for OneToN
  • #928 #956 black formatter is enabled
  • #896 #941 Some Python code cleanup
  • #867 get_contracts_deployment_info() returns None instead of raising a ValueError when no deployment file is found.
  • #863 Deploy 0.4.0 version on Goerli

0.18.0 - 2019-04-12

  • #831 Add contracts_version=0.11.1 that includes Görli deployment

0.17.2 - 2019-04-06

  • #813 expose mypy type checking results to the other packages.

0.17.1 - 2019-04-02

  • #809 fix a bug in get_contracts_deployment_info().

0.17.0 - 2019-03-27

0.16.0 - 2019-03-26

  • #775 Added contract_manager.get_contracts_deployed_info() that takes a module (SERVICES, RAIDEN or ALL) instead of services:bool
  • #775 Deprecated get_contracts_deployed() whose name sounded wrong and that had to be called twice.
  • #755 deploy script does not take --registry option anymore. Use --token-network-registry instead.

0.15.0 - 2019-03-19

  • #749 Fixed the problem where Monitoring Services were rewarded too late
  • #741 Removed raiden_contracts/contracts. Instead, please edit raiden_contracts/data/source directly.

0.14.0 - 2019-03-11

  • #720 Removed checks in MonitoringService.canMonitor() until the design is determined.
  • #696 ContractManager created with version=None has contracts_version == None
  • #678 Add a deployment-time configurable limit on the whole balance of UserDeposit
  • #678 Deployment script's service command takes an additional option --user-deposit-whole-limit

0.13.0 - 2019-03-04

0.12.0 - 2019-02-28

  • Add data/gas.json that contains gas measurements on the development version.
  • Move Raiden contracts to "raiden" subdir, so that the imports match the directory layout.
  • contracts_data_path, contracts_precompiled_path and contracts_gas_path require an additional flavor argument (either Flavor.Limited or Flavor.Unlimited).
  • Started providing Solidity sources next to the deployment data in raiden_contracts/data

0.11.0 - 2019-02-14

  • Deployed on testnets with a new fake token for service payments.

0.10.1 - 2019-02-13

  • #557 Revert the new gas measurements

0.10.0 - 2019-02-13

0.9.0 - 2019-01-23

  • raiden-network/raiden-contracts@v0.8.0...v0.9.0
  • various changes in the smart contract comments
  • various documentation updates
  • internal tests structure updates
  • addition of docstrings in the existing tests
  • #426 Add support for deploying the testnet 0.3._ version (not to be used in production)
  • #407 Fix bug in deployment that recompiled the contracts
  • #396 Introducing mypy in Travis builds
  • #379 #404 Removing raiden-libs dependency
  • #372 MSC - Prefix reward hash with "Ethereum Signed Message"
  • #366 Additional MonitoringService require check
  • #363 Refactor equals() function
  • #360 Update monitoring service to core contracts changes

0.8.0 - 2018-11-12

Changed

0.7.0 - 2018-10-25

Changed

0.6.0 - 2018-10-17

Changed

0.5.1 - 2018-10-12

Changed

0.5.0 - 2018-10-11

Changed

0.4.1 - 2018-10-05

Changed

pirapira added a commit to pirapira/spec that referenced this issue Sep 4, 2019
@pirapira
Add new attributes in events
e52734c 
This follows a change in the implementation
https://github.com/raiden-network/raiden-contracts/pull/1118/files

Two events got new arguments.

This commit is a part of solving raiden-network#253
@pirapira pirapira mentioned this issue Sep 4, 2019
Merged
pirapira added a commit to pirapira/spec that referenced this issue Sep 5, 2019
@pirapira
Add locksroots in ChannelSettled event
cf12d73 
This follows the implementation change made in
raiden-network/raiden-contracts#1126

This commit is a part of updating the spec
raiden-network#253
@pirapira pirapira mentioned this issue Sep 5, 2019
Merged
pirapira added a commit to pirapira/spec that referenced this issue Sep 5, 2019
@pirapira
Add description of the deprecation switch
334045e 
I wanted to add a new event about the deprecation switch, but
the deprecation was never explained in the spec.

This commit is a part of updating the spec according to the implementation
raiden-network#253
@pirapira pirapira mentioned this issue Sep 5, 2019
Merged
pirapira added a commit to pirapira/spec that referenced this issue Sep 5, 2019
@pirapira
Add expiration_block to setTotalWithdraw() args
8bb3e25 
This commit adds the new argument `expiration_block` to
`setTotalWithdraw()` function.

The change follows the implementation
raiden-network/raiden-contracts#1103

This commit is a part of updating the spec
raiden-network#253
@pirapira pirapira mentioned this issue Sep 5, 2019
Merged
pirapira added a commit to pirapira/spec that referenced this issue Sep 5, 2019
@pirapira
Rename unlock participants
2171c68 
from participant and partner into receiver and sender.

This change reflects the change made in the implementation
https://github.com/raiden-network/raiden-contracts/pull/988/files

This commit is a part of updating the spec
raiden-network#253
@pirapira pirapira mentioned this issue Sep 5, 2019
Merged
pirapira added a commit to pirapira/spec that referenced this issue Sep 5, 2019
@pirapira
Hashlocks are on SHA256 now
0e658a6 
The implementation changed the hash function
for the hashtimelocks
raiden-network/raiden-contracts#979

This commit reflects that in the spec.

This commit is a part of updating the spec:
raiden-network#253
@pirapira pirapira mentioned this issue Sep 5, 2019
Merged
pirapira added a commit to pirapira/spec that referenced this issue Sep 5, 2019
@pirapira
setTotalWithdraw function is available now
c8d466c 
The implementation re-enabled setTotalWithdraw in
raiden-network/raiden-contracts#711

This commit reflects the change in the spec.

This commit is a part of updating the spec:
raiden-network#253
@pirapira pirapira mentioned this issue Sep 5, 2019
Merged
palango pushed a commit that referenced this issue Sep 5, 2019
@pirapira @palango
Add new attributes in events
f65cddb 
This follows a change in the implementation
https://github.com/raiden-network/raiden-contracts/pull/1118/files

Two events got new arguments.

This commit is a part of solving #253
palango pushed a commit that referenced this issue Sep 5, 2019
@pirapira @palango
setTotalWithdraw function is available now
3dd5d11 
The implementation re-enabled setTotalWithdraw in
raiden-network/raiden-contracts#711

This commit reflects the change in the spec.

This commit is a part of updating the spec:
#253
palango pushed a commit that referenced this issue Sep 5, 2019
@pirapira @palango
Rename unlock participants
4ca33ee 
from participant and partner into receiver and sender.

This change reflects the change made in the implementation
https://github.com/raiden-network/raiden-contracts/pull/988/files

This commit is a part of updating the spec
#253
palango pushed a commit that referenced this issue Sep 5, 2019
@pirapira @palango
Add locksroots in ChannelSettled event
36c7187 
This follows the implementation change made in
raiden-network/raiden-contracts#1126

This commit is a part of updating the spec
#253
palango pushed a commit that referenced this issue Sep 5, 2019
@pirapira @palango
Hashlocks are on SHA256 now
705c5e2 
The implementation changed the hash function
for the hashtimelocks
raiden-network/raiden-contracts#979

This commit reflects that in the spec.

This commit is a part of updating the spec:
#253
palango pushed a commit that referenced this issue Sep 5, 2019
@pirapira @palango
Add description of the deprecation switch
cb5f9e1 
I wanted to add a new event about the deprecation switch, but
the deprecation was never explained in the spec.

This commit is a part of updating the spec according to the implementation
#253
pirapira added a commit to pirapira/spec that referenced this issue Sep 5, 2019
@pirapira
Add expiration_block to setTotalWithdraw() args
51b4a13 
This commit adds the new argument `expiration_block` to
`setTotalWithdraw()` function.

The change follows the implementation
raiden-network/raiden-contracts#1103

This commit is a part of updating the spec
raiden-network#253
pirapira added a commit to pirapira/spec that referenced this issue Sep 5, 2019
@pirapira
Add new arguments of createERC20TokenNetwork()
71b730e 
This follows the change in the implementation
raiden-network/raiden-contracts#655

This commit is a part of updating the specification:
raiden-network#253
@pirapira pirapira mentioned this issue Sep 5, 2019
Merged
pirapira added a commit to pirapira/spec that referenced this issue Sep 6, 2019
@pirapira
Explain more attributes of TokenNetwork
a623ac3 
This is a part of updating the spec
raiden-network#253

I had to add ``channel_participant_deposit_limit`` and
``token_network_deposit_limit``.  And then I noticed
that the attributes were never described.

I added new attributes and explained attributes.
@pirapira pirapira mentioned this issue Sep 6, 2019
Merged
pirapira added a commit to pirapira/spec that referenced this issue Sep 6, 2019
@pirapira
Explain more attributes of TokenNetwork
d4e9dad 
This is a part of updating the spec
raiden-network#253

I had to add ``channel_participant_deposit_limit`` and
``token_network_deposit_limit``.  And then I noticed
that the attributes were never described.

I added new attributes and explained attributes.
palango pushed a commit that referenced this issue Sep 6, 2019
@pirapira @palango
Add expiration_block to setTotalWithdraw() args
a0ce2a5 
This commit adds the new argument `expiration_block` to
`setTotalWithdraw()` function.

The change follows the implementation
raiden-network/raiden-contracts#1103

This commit is a part of updating the spec
#253
@pirapira
Copy link
Contributor Author

pirapira commented Sep 6, 2019 •
edited

When all PRs are merged, this issue can be closed.

palango pushed a commit that referenced this issue Sep 9, 2019
@pirapira @palango
Explain more attributes of TokenNetwork
5b5a556 
This is a part of updating the spec
#253

I had to add ``channel_participant_deposit_limit`` and
``token_network_deposit_limit``.  And then I noticed
that the attributes were never described.

I added new attributes and explained attributes.
@pirapira
Copy link
Contributor Author

Everything has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pirapira pirapira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pirapira