Skip to content

Commit

Permalink
scenarios: Wait longer before checking reward claims
Browse files Browse the repository at this point in the history
We sometimes see failures for this in CI, so let's give the MS a bit more time.
  • Loading branch information
palango authored and istankovic committed Oct 18, 2021
1 parent c8be4e0 commit bd03933
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions raiden/tests/scenarios/bf1_basic_functionality.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,8 @@ scenario:
event_args: {closing_participant: 3}

## Monitored channel must be settled before the monitoring service can claim its reward.
## To make sure the transactions gets mined in time, 5 additional blocks are added
## To make sure the transactions gets mined in time, 20 additional blocks are added
## Monitoring Service only reacts for the second closing because node4 settled to first
## channel itself
- wait_blocks: 5
- wait_blocks: 20
- assert_ms_claim: {channel_info_key: "MS Test Channel 3-4"}
4 changes: 2 additions & 2 deletions raiden/tests/scenarios/ms1_simple_monitoring.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@ scenario:
event_args: {closing_participant: 0}

## Monitored channel must be settled before the monitoring service can claim its reward
## To make sure the transactions gets mined in time, 10 additional blocks are added
- wait_blocks: 10
## To make sure the transactions gets mined in time, 20 additional blocks are added
- wait_blocks: 20
- assert_ms_claim: {channel_info_key: "MS Test Channel"}
4 changes: 2 additions & 2 deletions raiden/tests/scenarios/ms1_simple_monitoring_snapshot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ scenario:
event_args: {closing_participant: 0}

## Monitored channel must be settled before the monitoring service can claim its reward
## To make sure the transactions gets mined in time, 10 additional blocks are added
- wait_blocks: 10
## To make sure the transactions gets mined in time, 20 additional blocks are added
- wait_blocks: 20
- assert_ms_claim: {channel_info_key: "MS Test Channel"}
4 changes: 2 additions & 2 deletions raiden/tests/scenarios/ms2_simple_monitoring.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@ scenario:
- start_node: 1

## Monitored channel must be settled before the monitoring service can claim its reward
## To make sure the transactions gets mined in time, 10 additional blocks are added
- wait_blocks: 10
## To make sure the transactions gets mined in time, 20 additional blocks are added
- wait_blocks: 20
- assert_ms_claim: {channel_info_key: "MS Test Channel"}
4 changes: 2 additions & 2 deletions raiden/tests/scenarios/ms3_simple_monitoring.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ scenario:

## Monitored channel must be settled before the monitoring service can claim its reward
## We already waited 22 blocks, so we can subtract that from the settlement_timeout_min.
## Add 10 blocks as safety margin.
- wait_blocks: {{ settlement_timeout_min - 22 + 10 }}
## Add 20 blocks as safety margin.
- wait_blocks: {{ settlement_timeout_min - 22 + 20 }}
# will fail for now since channel was closed by node1.
- assert_ms_claim: {channel_info_key: "MS Test Channel", must_claim: False}

0 comments on commit bd03933

Please sign in to comment.