Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventTransferSentSuccess should contain `amount` and `target` #1010

Closed
konradkonrad opened this Issue Sep 13, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@konradkonrad
Copy link
Collaborator

konradkonrad commented Sep 13, 2017

Problem Definition

Currently EventTransferSentSuccess events are only informative, if the user keeps an out-of-band book over all initiated transfers and their respective identifiers. I.e.

    {
        "block_number": 1666812,
        "event_type": "EventTransferSentSuccess",
        "identifier": 1266537366290712202
    }

does not allow to learn anything about the details of the transfer.

Solution

EventTransferSentSuccess should mirror EventTransferReceivedSuccess and contain the fields

  • amount
  • target
    as well.

Tasklist

  • Add amount and target to EventTransferSentSuccess
  • Add tests for correct values for these fields
  • Adjust the API endpoint, specs & docs to include these
  • Adjust the webui implementation to make use of these

@czepluch czepluch self-assigned this Sep 14, 2017

@LefterisJP LefterisJP added this to the Next minor release milestone Sep 14, 2017

@LefterisJP LefterisJP added the 2 label Sep 14, 2017

@czepluch

This comment has been minimized.

Copy link
Collaborator

czepluch commented Sep 21, 2017

Closed with #1043

@czepluch czepluch closed this Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.