Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gas_price overwrite from cli #1097

Merged
merged 3 commits into from Nov 13, 2017
Merged

gas_price overwrite from cli #1097

merged 3 commits into from Nov 13, 2017

Conversation

hackaugusto
Copy link
Contributor

No description provided.

@palango
Copy link
Contributor

palango commented Oct 26, 2017

Can you rebase and maybe but the unrelated changes (regexes, except ...) in its own commit. Otherwise looks good.

@hackaugusto hackaugusto mentioned this pull request Oct 26, 2017
Closed
@LefterisJP
Copy link
Contributor

Also looks good to me but requires a changelog entry too, as it adds a new CLI argument.

@hackaugusto
Copy link
Contributor Author

done

@LefterisJP
Copy link
Contributor

approved

@hackaugusto hackaugusto merged commit 3a12cc8 into raiden-network:master Nov 13, 2017
@hackaugusto hackaugusto deleted the gas_price branch November 13, 2017 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LefterisJP LefterisJP LefterisJP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hackaugusto @palango @LefterisJP