Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to Rest API methods #2078

Closed
ulope opened this issue Aug 7, 2018 · 3 comments
Closed

Add logging to Rest API methods #2078

ulope opened this issue Aug 7, 2018 · 3 comments

Comments

@ulope
Copy link
Collaborator

ulope commented Aug 7, 2018

Problem Definition

Currently the Rest API layer contains no logging calls at all. That is sub-optimal, especially for longer running and chain interacting requests such as channel opening, deposit, close etc. since there is no indication in the log that anything is happening until chain events start coming back which can take quite a while depending on block time, chain congestion etc.

Solution: Add logging calls at least to the Rest API layer for at least long-running operations.

@LefterisJP
Copy link
Contributor

So you mean something like "Requesting X endpoint with A, B, C.. arguments before each call to the underlying python API?

@andrevmatos
Copy link
Contributor

Notice flask already do some logging for every request. We may want to get that suppressed if we plan to add our own, more informative logging to these calls.

@ulope
Copy link
Collaborator Author

ulope commented Aug 7, 2018

@LefterisJP Yeah basically. Maybe with the messages more oriented on the business logic though (e.g. Create channel request partner=0x... token=0x... deposit=...

@andrevmatos The flask logging is fine but only happens after the request is completed which won't help with long running ones.

@hackaugusto hackaugusto added this to the Red Eyes Testnet5 milestone Aug 13, 2018
@palango palango self-assigned this Aug 15, 2018
@palango palango mentioned this issue Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants