New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

echo_node has to depend on get_payment_events_for_token #2164

Closed
CosminNechifor opened this Issue Aug 13, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@CosminNechifor
Collaborator

CosminNechifor commented Aug 13, 2018

Problem Definition

After the changes I did in #2038 where the payment endpoint was added, the echo_node has to be changed, at the moment it uses get_channel_events which returns more then just the payment events. It should use the get_payment_events_for_token.

This brings us to another problem, we should adapt the logic of the echo_node... previously the get_channel_events was returning a dictionary and now the get_payment_events_for_token returns a tuple.

Proposed solutions

Change the logic of the echo_node to ensure it works with the output provided by get_payment_events_for_token, or convert the returned values to match the previous types.

@palango

This comment has been minimized.

Collaborator

palango commented Aug 13, 2018

Fixed by #2165

@palango palango closed this Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment