New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the state changes for the Delivered and Processed sender #2568

Closed
hackaugusto opened this Issue Sep 24, 2018 · 1 comment

Comments

Projects
None yet
5 participants
@hackaugusto
Collaborator

hackaugusto commented Sep 24, 2018

The state changes that correspond to the delivered and processed message must have the address of the sender, this address must be authenticated by some means that are dependent to the transport layer (currently the message itself contains a signature which must be recovered)

  • Add the sender to the Delivered and Processed state changes

  • Update the node.py handle_delivered to validate the sender

  • Update the node.py handle_processed to validate the sender

  • Create a marker state_change which all Receive* state changes inherit from

  • Remove "authentication" check (sender == recipient) from the transport and leave it to the state machines.

@hackaugusto hackaugusto added this to the Red Eyes Testnet 11 milestone Sep 24, 2018

@andrevmatos

This comment has been minimized.

Collaborator

andrevmatos commented Sep 24, 2018

Related to #2295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment