Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only poll for events from confirmed blocks #2711

Closed
hackaugusto opened this issue Oct 8, 2018 · 1 comment
Closed

Only poll for events from confirmed blocks #2711

hackaugusto opened this issue Oct 8, 2018 · 1 comment
Assignees

Comments

@hackaugusto
Copy link
Contributor

hackaugusto commented Oct 8, 2018

Abstract

Reorgs may change the order transactions are executed, the new order may make a previously successful transaction fail, or change the order of events. To avoid races we need to wait for the blocks to be confirmed.

Motivation

This has introduce a few bugs #2449 #2658 #2664

Specification

The event filter should just lag behind by confirmations blocks.

Backwards Compatibility

This will not introduce backwards compatibility issues, but it will add a bit of latency for the secret registration, which is not a problem with the current version of the smart contracts because of the secret registry.

Related

Take chain reorg into account #1121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants