New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed expired lock must validate the expiration #2720

Closed
hackaugusto opened this Issue Oct 8, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@hackaugusto
Collaborator

hackaugusto commented Oct 8, 2018

is_valid_expired_lock currently is not validating if the lock is expired.

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 8, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

@LefterisJP LefterisJP added this to the Red Eyes Testnet 13 milestone Oct 8, 2018

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 9, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 9, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 9, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 9, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 9, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 10, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 10, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 10, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 10, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 10, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 11, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 11, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 11, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

hackaugusto added a commit to hackaugusto/raiden that referenced this issue Oct 11, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix raiden-network#2720

LefterisJP added a commit that referenced this issue Oct 12, 2018

bugfix: lock expiration must be considered
A lock expired message must be ignored if the current block number is
smaller than the lock's expiration. Additionally, the receiver must wait
until the block in which the lock expired is confirmed, this is necesary
to handle the corner case where:

- The secret registration ocurred near the lock expiration
- A reorg happened
- The user's node was following the blocks which didn't have he secret
  registered in time

fix #2720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment