-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden messages against replay attacks #39
Comments
This should be taken care of with #93 that will introduce nonce ranges. |
Merged
konradkonrad
added a commit
that referenced
this issue
Jan 27, 2017
Final additions for the hardening against error conditions Fixes #39
err508
pushed a commit
that referenced
this issue
Aug 22, 2018
Refactor SC - balance_hash, batch unlock
hackaugusto
pushed a commit
to hackaugusto/raiden
that referenced
this issue
Dec 5, 2019
Add gevent compatible matrix client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Depending on the value of
self.asset
, messages could be re-applicable between two instances of the same state channel(between=[Alice, Bob], asset=BBCoin)
. Given that:If
self.asset
resolves to the same value, there seems to be no value unique to the current instance, i.e. yesterdays messages could be valid in today's channel.So: either the asset-address needs to be unique, or we should include the state-channel address in signed transfer messages.
See:
https://github.com/brainbot-com/raiden/blob/master/raiden/messages.py#L291
https://github.com/brainbot-com/raiden/blob/master/raiden/messages.py#L394
The text was updated successfully, but these errors were encountered: