Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix >= v1.0.0 limits display name field to 100 chars #4634

Closed
ulope opened this issue Aug 16, 2019 · 2 comments
Closed

Matrix >= v1.0.0 limits display name field to 100 chars #4634

ulope opened this issue Aug 16, 2019 · 2 comments
Labels
Component / Transport Transport related issues

Comments

@ulope
Copy link
Collaborator

ulope commented Aug 16, 2019 •
edited
Loading

Sub issue of: #3387

Problem Definition

synapse >= v1.0.0 introduced (matrix-org/synapse@d16c637) a length limit on the User displayname field of 100 characters.

This breaks our use of this field as a way to publish hex encoded ecrecover signatures since those need 132 characters.

Possible solutions

  1. Get Matrix to change the limit: New 100 char display name length limit is too restrictive matrix-org/synapse#5870
  2. Switch to base64 encoding (which would fit at 89 chars for a signature)
  3. Switch to use avatar_url field which has a limit of 1000 chars

All but 1. would be backwards incompatible (which currently should be doable) and would need coordination with the light client (ping @andrevmatos).
@ulope ulope changed the title Matrix >= 1.3 limits display name field to 100 chars Matrix >= 1.2.1 limits display name field to 100 chars Aug 19, 2019
ulope added a commit to ulope/raiden that referenced this issue Aug 19, 2019
@ulope
Switch to Synapse >= 1.0
4633a64 
(Not mergable currently because of raiden-network#4634. Temporarily uses the base64
solution mentioned in the issue.)

This updates our testing dependency to matrix-synapse 1.2.1.

The Synapse config files generated by the integration tests have been
updated to align with new / changed options.

Additionally this no longer uses local TLS certificates speeding up
tests.

Fixes: raiden-network#3387
Required for: raiden-network#4292
@ulope ulope mentioned this issue Aug 19, 2019
Merged
@ulope
Copy link
Collaborator Author

ulope commented Aug 28, 2019 •
edited
Loading

Good news, the Matrix team increased the length limit to 256 chars: matrix-org/synapse#5906!

Now we only need to wait for them to make a new release. I asked in the linked issue if there's an ETA for that.

@ulope ulope changed the title Matrix >= 1.2.1 limits display name field to 100 chars Matrix >= v0.99.5.2 limits display name field to 100 chars Sep 23, 2019
@ulope ulope changed the title Matrix >= v0.99.5.2 limits display name field to 100 chars Matrix >= v1.0.0 limits display name field to 100 chars Sep 23, 2019
@ulope ulope mentioned this issue Sep 25, 2019
Closed
ulope added a commit to ulope/raiden-service-bundle that referenced this issue Sep 25, 2019
@ulope
Apply patch for DISPLAY_NAME length limit
ca618c8 
Refs: raiden-network/raiden#4634
ulope added a commit to ulope/raiden-service-bundle that referenced this issue Sep 25, 2019
@ulope
Apply patch for DISPLAY_NAME length limit
687aea6 
Refs: raiden-network/raiden#4634
ulope added a commit to ulope/raiden-service-bundle that referenced this issue Sep 25, 2019
@ulope
Apply patch for DISPLAY_NAME length limit
10b3b86 
Refs: raiden-network/raiden#4634
ulope added a commit to ulope/raiden-service-bundle that referenced this issue Sep 25, 2019
@ulope
Apply patch for DISPLAY_NAME length limit
93c287d 
Refs: raiden-network/raiden#4634
ulope added a commit to ulope/raiden-service-bundle that referenced this issue Sep 25, 2019
@ulope
Apply patch for DISPLAY_NAME length limit
cd45aa4 
Refs: raiden-network/raiden#4634
ulope added a commit to ulope/raiden-service-bundle that referenced this issue Sep 25, 2019
@ulope
Apply patch for DISPLAY_NAME length limit
ca757a6 
Refs: raiden-network/raiden#4634
ulope added a commit to ulope/raiden-service-bundle that referenced this issue Sep 26, 2019
@ulope
Apply patch for DISPLAY_NAME length limit
e6529a0 
Refs: raiden-network/raiden#4634
ulope added a commit to ulope/raiden-service-bundle that referenced this issue Sep 26, 2019
@ulope
Apply patch for DISPLAY_NAME length limit
f2cb521 
Refs: raiden-network/raiden#4634
ulope added a commit to ulope/raiden that referenced this issue Sep 30, 2019
@ulope
Switch to Synapse >= 1.0
acfb515 
(Not mergable currently because of raiden-network#4634. Temporarily uses the base64
solution mentioned in the issue.)

This updates our testing dependency to matrix-synapse 1.2.1.

The Synapse config files generated by the integration tests have been
updated to align with new / changed options.

Additionally this no longer uses local TLS certificates speeding up
tests.

Fixes: raiden-network#3387
Required for: raiden-network#4292
LefterisJP pushed a commit that referenced this issue Oct 1, 2019
@ulope @LefterisJP
Switch to Synapse >= 1.0
4cf077e 
(Not mergable currently because of #4634. Temporarily uses the base64
solution mentioned in the issue.)

This updates our testing dependency to matrix-synapse 1.2.1.

The Synapse config files generated by the integration tests have been
updated to align with new / changed options.

Additionally this no longer uses local TLS certificates speeding up
tests.

Fixes: #3387
Required for: #4292
@ulope
Copy link
Collaborator Author

ulope commented Oct 1, 2019

We upgraded to synapse 1.4.0rc1 for now.

Once 1.4.0 is released we can switch to that.

@ulope ulope closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component / Transport Transport related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ulope