Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary fees due to channel partners being offline when using the connection manager #5583

Closed
taleldayekh opened this issue Jan 7, 2020 · 1 comment · Fixed by #5633
Closed

Avoid unnecessary fees due to channel partners being offline when using the connection manager #5583

taleldayekh opened this issue Jan 7, 2020 · 1 comment · Fixed by #5633
Assignees
@LefterisJP
Labels
Component / WebUI Type / Optimization Issues that are performance related
Projects
Raiden Berlin Sprint
Milestone
Alderaan

Comments

@taleldayekh
Copy link
Contributor

In its current implementation, the connection manager that is used for opening channels when joining a token network might also connect you with nodes that happen to be offline.

This leads to unnecessary fees that have to be paid for on-chain transactions just to move the funds around. Apparently, there is a quick fix for this. :)
@Dominik2002 Dominik2002 added this to Backlog in Raiden Berlin Sprint Jan 7, 2020
@Dominik2002 Dominik2002 added Type / Optimization Issues that are performance related Component / WebUI labels Jan 7, 2020
@Dominik2002 Dominik2002 added this to the Alderaan milestone Jan 7, 2020
@Dominik2002 Dominik2002 changed the title Avoid unnecessary fees due to node beign offline when using the connection manager Avoid unnecessary fees due to channel partners being offline when using the connection manager Jan 7, 2020
@palango
Copy link
Contributor

palango commented Jan 8, 2020

Similar to #5453

@Dominik1999 Dominik1999 moved this from Backlog to Sprint Backlog (Team does that) in Raiden Berlin Sprint Jan 8, 2020
@Dominik1999 Dominik1999 moved this from Sprint Backlog (Team does that) to In progress in Raiden Berlin Sprint Jan 8, 2020
LefterisJP added a commit to LefterisJP/raiden that referenced this issue Jan 10, 2020
@LefterisJP
If a node is offline connect() no longers opens a channel with it
63d26c5 
Fix raiden-network#5583
@LefterisJP LefterisJP mentioned this issue Jan 10, 2020
Merged
13 tasks
@Dominik1999 Dominik1999 moved this from In progress to Backlog in Raiden Berlin Sprint Jan 13, 2020
@Dominik1999 Dominik1999 moved this from Backlog to Review in progress in Raiden Berlin Sprint Jan 13, 2020
@palango palango mentioned this issue Jan 13, 2020
Closed
LefterisJP added a commit to LefterisJP/raiden that referenced this issue Jan 14, 2020
@LefterisJP
If a node is offline connect() no longers opens a channel with it
b46236b 
Fix raiden-network#5583
LefterisJP added a commit to LefterisJP/raiden that referenced this issue Jan 22, 2020
@LefterisJP
If a node is offline connect() no longers opens a channel with it
63ad996 
Fix raiden-network#5583
Raiden Berlin Sprint automation moved this from Review in progress to Done Jan 27, 2020
palango pushed a commit that referenced this issue Jan 27, 2020
@LefterisJP @palango
If a node is offline connect() no longers opens a channel with it
297f96d 
Fix #5583
hackaugusto pushed a commit that referenced this issue May 29, 2020
@LefterisJP @hackaugusto
If a node is offline connect() no longers opens a channel with it
51e4dbd 
Fix #5583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LefterisJP LefterisJP

Labels
Component / WebUI Type / Optimization Issues that are performance related
Projects
Raiden Berlin Sprint
  
Done
Milestone
Alderaan
Development

Successfully merging a pull request may close this issue.

If a node is offline connect() no longers opens a channel with it LefterisJP/raiden
4 participants
@palango @LefterisJP @taleldayekh @Dominik2002