Fix print of syncing message #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LefterisJP
force-pushed
the
fix_print_of_syncing_message
branch
from
f308910
to
554c5d5
Compare
hackaugusto
reviewed
Jul 23, 2018
| @@ -173,7 +173,7 @@ def wait_for_sync_etherscan( | |||
| ) -> None: | |||
| local_block = blockchain_service.client.block_number() | |||
| etherscan_block = etherscan_query_with_retries(url, sleep) | |||
| syncing_str = 'Syncing ... Current: {} / Target: ~{}' | |||
| syncing_str = '\rSyncing ... Current: {} / Target: ~{}' | |||
There was a problem hiding this comment.
If you want to use carriage return, could you please remove the line which is printing the ansi codes?
hackaugusto
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1911