logging: logs before & after all transactions #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackaugusto
changed the title
hackaugusto
force-pushed
the
proxis_logging
branch
from
7d35d36
to
07c5a2e
Compare
To make debugging easier some of the proxies have logs for before and after the transaction is sent. This adds these logs lines to the missing proxies. The general guidelined followed was: - logs prior to the transaction sent are debugging logs - logs after the transaction is mined are: - critical if the transaction failed in an unrecoverable manner - info if the transaction failed in a recoverable manner - info if the transaction was successful - the logs are formatedd with `<smart_contract_function_name> <state>`, where state is one of these: - called - failed - successful This did improve the logging but it's not covering all cases, specially the checks done in the channel proxy which can raise an exception
hackaugusto
force-pushed
the
proxis_logging
branch
from
07c5a2e
to
cbe908e
Compare
palango
approved these changes
Sep 25, 2018
| @@ -150,20 +150,22 @@ def new_netting_channel( | |||
| if self.node_address == partner: | |||
| raise SamePeerAddress('The other peer must not have the same address as the client.') | |||
|
|
|||
| log_details = { | |||
| 'peer1': pex(self.node_address), | |||
There was a problem hiding this comment.
These should be called participant, we never use peer as far as I know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make debugging easier some of the proxies have logs for before and
after the transaction is sent. This adds these logs lines to the missing
proxies.
The general guidelined followed was:
<smart_contract_function_name> <state>,where state is one of these:
This did improve the logging but it's not covering all cases, specially
the checks done in the channel proxy which can raise an exception