New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle transaction execution error for parity #2986

Merged

palango merged 2 commits into raiden-network:master from LefterisJP:handle_transaction_execution_error_for_parity

Nov 9, 2018

Contributor

LefterisJP commented Nov 8, 2018

Triggered by #2984

We now recognize when parity's estimate gas tells us the transaction will always fail
Fixed a bug where we were not detecting the TRANSACTION_UNDERPRICED case for parity

LefterisJP added 2 commits

November 8, 2018 18:29


          Handle the always fail case of estimate gas in parity

e0c2dd5


          Properly return TRANSACTION_UNDERPRICED for parity

34e43de

LefterisJP added the dev: Please Review label

LefterisJP mentioned this pull request

A crash occurs during settle gas estimation #2984

Closed

palango approved these changes

View reviewed changes

Contributor

palango left a comment

Looks good.

palango merged commit 81cd7b6 into raiden-network:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment