Check recipient in nettingchannel #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add (currenctly failing) tests for checking if the recipient of a messaged submitted via close() or updateTransfer() is actually a participant of the channel. - In some tests in test_close.py and test_updateTransfer the nonce was incorrectly specofied and the test was failing due to the nonce and not due to the expected failure.
czepluch
previously approved these changes
May 18, 2017
There was a problem hiding this comment.
Looking good. Thanks for the quick fix and short response time @LefterisJP !
|
tests are not passing * |
|
@czepluch will have a look but don't dimiss the review unless you are available for a re-review when needed |
|
I am here waiting for you ;) |
czepluch
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #601
Add tests for checking if the recipient of a
messaged submitted via close() or updateTransfer() is actually a
participant of the channel.
In some tests in test_close.py and test_updateTransfer the nonce was
incorrectly specofied and the test was failing due to the nonce and not
due to the expected failure.
Add a check in both
updateTransfer()andclose()that makes sure the recipient of a message we try to close/update with is indeed the expected channel participant.