Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【WIP】Add each_serializer option support to CollectionSerializer #2409

Conversation

tashirosota
Copy link

@tashirosota tashirosota commented Jan 30, 2021

Purpose

Changes

  • lib/active_model/serializer/collection_serializer.rb :43 add check to each_serializer option

Related GitHub issues

Additional helpful information

  • Our production project has passed all rspec by this patch

@tashirosota tashirosota changed the base branch from master to 0-10-stable January 30, 2021 07:35
@tashirosota tashirosota changed the title tashirosota/v0.10/issues/2406 Add each_serializer option support to CollectionSerializer Jan 30, 2021
@@ -18,8 +18,8 @@ def custom_options
instance_options
end
end
class MessagesSerializer < ActiveModel::Serializer
type 'messages'
class MessageSerializer < ActiveModel::Serializer
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serializer class is singular most of the time.

@tashirosota tashirosota changed the title Add each_serializer option support to CollectionSerializer 【WIP】Add each_serializer option support to CollectionSerializer Feb 4, 2021
@tashirosota tashirosota closed this Feb 5, 2021
@tashirosota tashirosota deleted the tashirosota/v0.10/issues/2406 branch February 11, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant