Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for symbolizing :root key #317

Closed
wants to merge 1 commit into from
Closed

Test for symbolizing :root key #317

wants to merge 1 commit into from

Conversation

ahawkins
Copy link
Contributor

Ensure that a String or Symbol can use with :root.

@steveklabnik
Copy link
Contributor

This doesn't merge cleanly.

/cc @spastorino

@ahawkins
Copy link
Contributor Author

@spastorino @steveklabnik rebased.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 453db49 on ahawkins:root-key-fix into 8795f2b on rails-api:master.

@ghost ghost assigned spastorino May 28, 2013
@mikegee
Copy link
Contributor

mikegee commented Aug 28, 2013

Are there some concerns keeping this from being merged?

@steveklabnik
Copy link
Contributor

Well, the build is failing.

Also, waiting on a large refactoring to drop before I merge anything.

@spastorino
Copy link
Contributor

This doesn't apply anymore after the rewrite. Please take a look if master is working because it should. Thanks for helping!.

@spastorino spastorino closed this Oct 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahawkins @steveklabnik @coveralls @mikegee @spastorino