move DefaultSerializer to a separate file, add tests

[teeparham]

Nothing was changed in DefaultSerializer. It was simply moved to a separate file.

[coveralls]

Coverage increased (+0%) when pulling c96095f on teeparham:default_serializer into 4f185ef on rails-api:master.

[mikegee]

I thought I saw something about work on a big rewrite, but it would be nice if someone could comment here on why this isn't being merged right now.

[steveklabnik]

Yup.

[teeparham]

@steveklabnik @spastorino

If there is a large rewrite happening with AMS, there should be a note in the Readme or an open Issue that says something like "we are only accepting bug fixes over the next [2 months/whenever], as we're re-writing the gem." It is discouraging to contributors to think that their valid work would be ignored. In any case, the communication could be handled better.

🌈🌈🌈

[steveklabnik]

This is one of those things where it's supposed to take a week, then takes longer, then takes longer... but yes, hindsight is 20/20.

[spastorino]

@teeparham neither your work or work done by other contributors will be ignored. I jumped here to help because lack of maintainers in the project. Will try to finish my work ASAP and then I'm going to take care of all the open issues and PRs.

[sorentwo]

@spastorino, @steveklabnik Thanks for getting back on top of communication. This is a project that is completely integral to all of the Rails work that I do and I appreciate knowing where it stands. I'm sure many of the other PR contributors feel the same.

Happy to help triage, test, advise where I can.

[teeparham]

@spastorino @steveklabnik To be clear, I merely wanted to make a friendly suggestion to keep commits small & frequent & to try to keep communication open for work in progress. Thanks to both of you for stepping up to be maintainers. I'm happy to continue to help & have obviously been a fan & contributor for a while.

[spastorino]

@teeparham thanks for helping, the delay is just my fault because I have a lot of stuff to do and couldn't finish it yet

[ghost]

Thank you @spastorino for your amazing work. 👍

[tjschuck]

@spastorino Any chance you could make this development a bit more public? Even just pushing up a branch that you're working on so we're not all left in the dark and where we can potentially provide our own feedback (and keep our own pull requests up-to-date with it).

It would be nice if this rewrite was carried out a bit more like the also-significant rewrite of ember-data was, where things were still done publicly in their jj-abrams branch so invested parties weren't blindsided by major changes.

I definitely appreciate all of your awesome work, and realize that life and "real work" can easily trump working on OSS, but it seems like you have quite a few people on here who would be willing to help out :)

❤️ ❤️ ❤️

[spastorino]

@tjschuck will do as soon as I can. Just need to polish some stuff.

[spastorino]

This is already in a different file in master. Thanks a lot for helping and sorry about the long delay. ❤️ ❤️ ❤️