Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation to warn users that { root: false } will ignore the meta key #337

Merged
merged 1 commit into from
Oct 21, 2013
Merged

Updating documentation to warn users that { root: false } will ignore the meta key #337

merged 1 commit into from
Oct 21, 2013

Conversation

lserman
Copy link
Contributor

@lserman lserman commented Jun 16, 2013

I discussed this in #332

I do not believe it is possible to include a meta key while using { root: false }. This is fine - the JSON would be invalid... but it would have helped me to read it in the meta section of the documentation.

davingee was also confused by this, as seen in #334

…} will cause the serializer to ignore the meta key as it leads to invalid JSON.

#332
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling b20ad33 on lserman:update-meta-key-docs into 4f185ef on rails-api:master.

@suciuvlad
Copy link

+1

1 similar comment
@variousauthors
Copy link

+1

spastorino added a commit that referenced this pull request Oct 21, 2013
Updating documentation to warn users that { root: false } will ignore the meta key
@spastorino spastorino merged commit 8f583d2 into rails-api:master Oct 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants