Minor documentation update about usage of options and scope #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ahmeij
commented
Jun 19, 2013
ahmeij
commented
- Be a bit more clear on the use of scope (fixing Documentation incorrectly advises use of "current_user" instead of "scope" #322)
- Bring up the details on how to pass options
|
Thanks, this is important stuff to know! |
|
@ahmeij can you rebase this against master?. Thanks. |
|
@spastorino I've done a lot of magic to get this to work, but I think I've got it. In theory the pull request should be up-to-date now, let me know if it is ok please. |
|
Could you squash those commits in one? thanks @ahmeij for the patch. |
| attributes :title, :body, :special | ||
|
|
||
| def include_special? | ||
| options[:do_something_special] |
There was a problem hiding this comment.
@options here, there's no accessor anymore in master.
|
Basically the entire pull-request is outdated compared to master, lets just drop it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.