Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to embed option #408

Closed
wants to merge 2 commits into from

Conversation

arthurnn
Copy link
Contributor

  • More tests to embed in class level Serializer.
  • Second test is marked as skip because is falling as we need to fix the SETTINGS constant on the Serializer.

EDIT
Removing SETTINGS global variable, and make it a class level settings.

review @spastorino

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.65%) when pulling 4c0b454 on arthurnn:embed_tests into c65d387 on rails-api:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 4bea0c9 on arthurnn:embed_tests into c65d387 on rails-api:master.

@arthurnn
Copy link
Contributor Author

After talking to @spastorino, we decide to close this, as the idea is to deprecate embed method on a pre-class basis, and make it global. Something like this:

ActiveModel::Serializer.setup do |settings|
  settings[:embed] = :ids
  settings[:include] = true
end

@arthurnn arthurnn closed this Oct 20, 2013
@arthurnn arthurnn deleted the embed_tests branch October 20, 2013 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants