Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicit serializer for associations #821

Merged
merged 2 commits into from
Mar 1, 2015
Merged

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Feb 25, 2015

I needed to apply this patch in order to get the explicit association serializers feature to work as expected with the has_many association. Looked like a probable typo (the feature PR #696 renamed :options to :association_options, and forgot to update this one to match).

I've updated the test_includes_linked_comments test with the proper expected result (the old test was not invoking the explicit has_many association serializer functionality at all).

@kurko kurko added the V: 0.10.x label Mar 1, 2015
kurko added a commit that referenced this pull request Mar 1, 2015
Fix explicit serializer for associations
@kurko kurko merged commit 77fb050 into rails-api:master Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants