root option is working (fixed #986)

[mareczek]

Will be very grateful for a quick resolution.

[bf4]

These tests are testing the value of Serializer#json_key, but the issue in #986 was

render json: @current_user, root: 'resource', adapter: :json

Which uses the transformations in the controller (something like JsonAdapter.create(ProfileSerializer.new(@post, root: 'smth')).serializable_hash). I'm not sure you just want to test ProfileSerializer.new(@post, root: 'smth').json_key as that's not testing the result you want:

{
-  "user": {
+  "resource": {
    "id": 1,
    "name": "Rambo"
  }
}

That said, the behavior you desire was specifically removed from AMS in #958

# controller
-    ADAPTER_OPTION_KEYS = [:include, :fields, :root, :adapter]
+    ADAPTER_OPTION_KEYS = [:include, :fields, :adapter]
# serializer
     def initialize(object, options = {})

-      @root       = options[:root] || (self.class._root ? self.class.root_name : false)
+      @root       = options[:root]

    def json_key
-      if root == true || root.nil?
-        self.class.root_name
-      else
-        root
-      end
+      self.class.root_name
     end
 # adapter

       def root
-        @options.fetch(:root) { serializer.json_key }
+        serializer.json_key.to_sym if serializer.json_key
       end

       def include_meta(json)
-        json[meta_key] = meta if meta && root
+        json[meta_key] = meta if meta
         json
       end

I brought up documenting these changes in #966 but it hasn't been merged/finalized yet

[joaomdmoura]

👍 Indeed. We could bring some of the older tests to validate it.

[joaomdmoura]

@mareczek could you check @bf4 comment? Maybe check #958, bring some tests back to this PR.

[vyrak]

One thing to note is that the root option is ignored when serializing an empty array.

[vyrak]

@joaomdmoura

The PR ported some tests from joaomdmoura@3296912. Let me know if there are other tests that need to be ported back.

[joaomdmoura]

Tks @vyrak, awesome, I'm closing this one in favor of #1013