Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Upgrade Ruby from 2.1.5 to latest version. #177

Closed
jasnow opened this issue Mar 31, 2015 · 5 comments
Closed

Upgrade Ruby from 2.1.5 to latest version. #177

jasnow opened this issue Mar 31, 2015 · 5 comments

Comments

@jasnow
Copy link
Contributor

jasnow commented Mar 31, 2015

As of March 30, 2015, Ruby version is 2.2.1.

  • Change version in all config files, such as .ruby-version, .travis.yml, etc.
  • Run bundle to create new gemset.
  • Clean up warnings and errors.
jasnow added a commit to jasnow/rgsoc-teams that referenced this issue Mar 31, 2015
@jasnow
Copy link
Contributor Author

jasnow commented Mar 31, 2015

Two loose ends:

  • WARNING: Nokogiri was built against LibXML version 2.9.1, but has dynamically loaded 2.8.0
  • Commented out one line in slim file. Tagged with "FIXME:". Use git grep FIXME to find it.

jasnow added a commit to jasnow/rgsoc-teams that referenced this issue Mar 31, 2015
@jasnow
Copy link
Contributor Author

jasnow commented Mar 31, 2015

Why is input_html listed twice in app/views/application_drafts/new.html.slim file (line 54)?

= f.input :misc_info, as: :text, label: 'Anything else to add?', 
input_html: { rows: 4 }, hint:
'Address anything that you feel is relevant to your application and was not covered previously.',
input_html: { disabled: !application_draft.as_student? || application_draft.applied? }

Unclear how to fix it.

@carpodaster
Copy link
Member

Ah, that must be a copy/paste error. Thanks for spotting it! Just put the rows: 4 in the 2nd input_html hash.

@jasnow
Copy link
Contributor Author

jasnow commented Mar 31, 2015

Show me the revised line and I will check it in and close this issue. THANKS...

@jasnow
Copy link
Contributor Author

jasnow commented Apr 1, 2015

Too confusing with closed PR so closing.

@jasnow jasnow closed this as completed Apr 1, 2015
carpodaster added a commit that referenced this issue Apr 1, 2015
Closes #178

commit a8503f5
Merge: 5390787 ac0dc8d
Author: Al Snow <jasnow@hotmail.com>
Date:   Wed Apr 1 08:11:23 2015 -0400

    Merge branch 'master' of https://github.com/rails-girls-summer-of-code/rgsoc-teams

commit 5390787
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 20:43:37 2015 -0400

    Revert "Changed Time.now to Time.zone.now"

    This reverts commit b915ae3.

commit 664bb7b
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 14:36:55 2015 -0400

    Upgraded ffaker gem to 2.0.0

commit c13891e
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 09:12:21 2015 -0400

    WIP: #177: Uncommented out FIXME line; Fixed nokogiri config issue

commit c235573
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 08:49:44 2015 -0400

    WIP: #177: Upgraded Ruby to 2.2.1

commit e9b40b8
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 08:39:57 2015 -0400

    WIP: Upgraded Ruby to 2.2.0 and Rails 4.1.10

commit b915ae3
Author: Al Snow <jasnow@hotmail.com>
Date:   Mon Mar 30 18:15:41 2015 -0400

    Changed Time.now to Time.zone.now
carpodaster added a commit that referenced this issue Apr 2, 2015
Closes #178

commit a8503f5
Merge: 5390787 ac0dc8d
Author: Al Snow <jasnow@hotmail.com>
Date:   Wed Apr 1 08:11:23 2015 -0400

    Merge branch 'master' of https://github.com/rails-girls-summer-of-code/rgsoc-teams

commit 5390787
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 20:43:37 2015 -0400

    Revert "Changed Time.now to Time.zone.now"

    This reverts commit b915ae3.

commit 664bb7b
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 14:36:55 2015 -0400

    Upgraded ffaker gem to 2.0.0

commit c13891e
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 09:12:21 2015 -0400

    WIP: #177: Uncommented out FIXME line; Fixed nokogiri config issue

commit c235573
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 08:49:44 2015 -0400

    WIP: #177: Upgraded Ruby to 2.2.1

commit e9b40b8
Author: Al Snow <jasnow@hotmail.com>
Date:   Tue Mar 31 08:39:57 2015 -0400

    WIP: Upgraded Ruby to 2.2.0 and Rails 4.1.10

commit b915ae3
Author: Al Snow <jasnow@hotmail.com>
Date:   Mon Mar 30 18:15:41 2015 -0400

    Changed Time.now to Time.zone.now
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants