Fix Rails 7 connection handling

[calmyournerves]

Related: #193

After trying to upgrade one of our apps to Rails 7 we saw some specs failing related to the monkey-patched connected_to method in lib/apartment/active_record/connection_handling.rb. Rails 7 removed the database: keyword for connected_to (rails/rails@ce629d9). This means apartment is currently not compatible with Rails 7.

This PR removes the deprecated database: keyword from the monkey patch. I'm not sure if this has any implications for Rails 6 users.
I also changed the monkey patch to be only included for ActiveRecord >= 6 (connected_to was introduced in Rails 6). I also attempted to write some specs for the monkey-patch.

[kapso]

Any plans for merging this PR? Thanks.

[archonic]

This has fixed issues I was having in the Rails 7 upgrade. Thanks @calmyournerves! Do you have any bandwidth to fix the rubocop failures? If not I could take a look.

[calmyournerves]

Just pushed a commit that simplifies the specs a little bit and should fix the rubocop stuff ✌️

[rpbaltazar]

Thank you for reporting and helping out on this. I think that for the sake of compatibility we may need to have 2 versions of the monkeypatch one that takes in the database keyword arg (before rails 6.2) and the other that doesn't for after 6.2.

[calmyournerves]

@rpbaltazar Different monkey patches is a good idea 👍

[kapso]

Any plans for releasing this?

[santanaluiz]

+1 on the release

[markedmondson]

Hey @rpbaltazar any chance of getting a release for this please? I'm happy to help out if you want to add me as a rubygems contributor? (https://rubygems.org/profiles/markedmondson)

[javierm]

@markedmondson In case it helps, I work on a project where, as a workaround, we've added this code to the apartment initializer:

module ActiveRecord
  module ConnectionHandling
    def connected_to_with_rails7_tenant(role: nil, prevent_writes: false, &blk)
      current_tenant = Apartment::Tenant.current

      # The connected_to_without_tenant method is defined by Apartment
      connected_to_without_tenant(role: role, prevent_writes: prevent_writes) do
        Apartment::Tenant.switch!(current_tenant)
        yield(blk)
      end
    end

    alias connected_to connected_to_with_rails7_tenant
  end
end

[mnovelo]

@markedmondson @javierm could you please try the latest version we just released? This should account for both Rails 7 and < 6.2 connection handling https://rubygems.org/gems/ros-apartment