Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix composite primary key with different data type with triggers #1164

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix composite primary key with different data type with triggers #1164

merged 1 commit into from
Apr 24, 2024

Conversation

vividmuimui
Copy link
Contributor

This PR allows adapter.exclude_output_inserted_table_names to specify the type of each primary key when trigger is set and there are tables with composite primary keys.

adapter.exclude_output_inserted_table_names['my_composite_pk_table_name'] = { pk_col_one: "uniqueidentifier", pk_col_two: "int" }

Fix #1163

@aidanharan aidanharan changed the base branch from main to 7-1-stable April 24, 2024 17:44
@aidanharan aidanharan changed the base branch from 7-1-stable to main April 24, 2024 17:44
@aidanharan aidanharan changed the title Fix composite pk with defferent data type with triggers Fix composite primary key with different data type with triggers Apr 24, 2024
@aidanharan aidanharan merged commit 7650860 into rails-sqlserver:main Apr 24, 2024
1 of 4 checks passed
@aidanharan
Copy link
Contributor

aidanharan commented Apr 24, 2024 •
edited
Loading

@vividmuimui Thanks for the PR!!!

aidanharan pushed a commit that referenced this pull request Apr 24, 2024
@vividmuimui @aidanharan
Fix composite primary key with different data type with triggers (#1164)
997c848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7-2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exclude_output_inserted_table_names does not support composite primary keys with different data types
2 participants
@vividmuimui @aidanharan