Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Freetds to match CI #1192

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update Freetds to match CI #1192

merged 1 commit into from
Jun 5, 2024

Conversation

aidanharan
Copy link
Contributor

Fix the following failing tests.

https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/actions/runs/9388881855/job/25855114274?pr=1190

  3) Failure:
SQLServerRakeStructureDumpLoadTest#test_0001_dumps structure and accounts for defncopy oddities [test/cases/rake_test_sqlserver.rb:144]:
Expected /email\s+nvarchar\(4000\)/ to match "\t/* No foreign keys reference table 'dbo.users', or you do not have permissions on referencing tables. */\n\t/* No views with schema binding reference table 'dbo.users'. */\n\nCREATE TABLE [dbo].[users]\n\t( [id]          bigint          NOT NULL\n\t, [name]        nvarchar(4000)      NULL\n\t, [email]       nvarchar(4000)      NULL\n\t, [background1] nvarchar(max)       NULL\n\t, [background2] text                NULL\n\t, [created_at]  datetime2       NOT NULL\n\t, [updated_at]  datetime2       NOT NULL\n\t)\n\nALTER TABLE [dbo].[users] ADD CONSTRAINT [PK__users__3213E83FA1874989] PRIMARY KEY clustered ([id])\n\n".

  4) Failure:
SQLServerRakeStructureDumpLoadTest#test_0002_can load dumped structure [test/cases/rake_test_sqlserver.rb:152]:
Expected /CREATE TABLE dbo\.users/ to match "\t/* No foreign keys reference table 'dbo.users', or you do not have permissions on referencing tables. */\n\t/* No views with schema binding reference table 'dbo.users'. */\n\nCREATE TABLE [dbo].[users]\n\t( [id]          bigint          NOT NULL\n\t, [name]        nvarchar(4000)      NULL\n\t, [email]       nvarchar(4000)      NULL\n\t, [background1] nvarchar(max)       NULL\n\t, [background2] text                NULL\n\t, [created_at]  datetime2       NOT NULL\n\t, [updated_at]  datetime2       NOT NULL\n\t)\n\nALTER TABLE [dbo].[users] ADD CONSTRAINT [PK__users__3213E83FA5447335] PRIMARY KEY clustered ([id])\n\n".

@aidanharan aidanharan marked this pull request as ready for review June 5, 2024 18:40
@aidanharan aidanharan merged commit 20d1c84 into main Jun 5, 2024
1 of 8 checks passed
@aidanharan aidanharan deleted the update-freetds branch June 5, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant