Dump column collation to schema.rb and allow collation changes using column_change #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to implement this on 6-0-stable since it's a small change. If it wasn't the right call and it should be targeting main, let me know. |
|
I've just realized that the issue was reported for 5-2-stable. The fix is almost the same. The only difference with this PR is that the change in and not I'm not sure what's the best here. I can make another PR for 5-2-stable. |
|
PRs should target the |
mgrunberg
force-pushed
the
issues/yellowspot/848_fix_schema_column_collection
branch
from
0dd6e80
to
d367bda
Compare
|
@wpolicarpo, no problem. I've rebased with main and changed target to main. |
|
LGTM. Can you resolve the changelog conflict? |
|
@wpolicarpo, conflicts fixed |
mgrunberg
deleted the
issues/yellowspot/848_fix_schema_column_collection
branch
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
…column_change (rails-sqlserver#881) * add column collation to schema dump. Dump string value * be able to alter column collation * spec showing collation change using 'change_column' * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address #848.
It also adds support to change collation
change_column :customers, :name, collation: :xxx. Before this change, collation changes were skipped/ignored.