Rails 6.1: Raise ActiveRecord::ConnectionNotEstablished on calls to execute with a disconnected connection.
#903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:StatementInvalid when call execute and connection is disconnected
wpolicarpo
reviewed
Apr 21, 2021
lib/active_record/connection_adapters/sqlserver/database_statements.rb
Outdated
Show resolved
Hide resolved
…d-refactor Refactor 'Raise ActiveRecord::ConnectionNotEstablished on calls to execute with a disconnected connection'
gisborne
reviewed
Apr 22, 2021
…ction" This reverts commit 6861763.
This was referenced Apr 27, 2021
mgrunberg
force-pushed
the
issues/yellowspot/rails-6-1/raise-connection-not-established
branch
from
fd30c0d
to
6b73a4e
Compare
mgrunberg
deleted the
issues/yellowspot/rails-6-1/raise-connection-not-established
branch
lavika
pushed a commit
to lavika/activerecord-sqlserver-adapter
that referenced
this pull request
Sep 26, 2023
… execute with a disconnected connection. (rails-sqlserver#903) * raise ActiveRecord::ConnectionNotEstablished instead of ActiveRecord::StatementInvalid when call execute and connection is disconnected * add test of other calls to connection.execute that should fail * add changelog item * Refactor * fix typo * check connection active to prevent usage of dead/closed connection * raise TinyTds::Error and translate it. 'active?' method is rescuing just those * Revert "check connection active to prevent usage of dead/closed connection" This reverts commit 6861763. * check TinyTds FalseClass response in execute_procedure and raw_connection_run * raise ConnectionNotEstabilished when TinyTDS returns false Co-authored-by: Aidan Haran <aharan@fusioneer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the failure:
Rails 6.1 expects that we raise an instance of
ActiveRecord::ConnectionNotEstablished(see https://github.com/rails/rails/blob/v6.1.0/activerecord/test/cases/disconnected_test.rb).Rails 6.0 was expecting
ActiveRecord::StatementInvalid. In fact, 6-0-stable raises that exception with the message:I use the fact that @connnection is nil to detect when to raise the exception.