Fix Errors#from_type use known_attributes #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the use of #attributes.keys with #known_attributes in Errors#from_array and Errors#from_hash. This is done so that when ActiveResource grabs errors for attributes defined in the schema, but don't yet exist as an attribute on the object, the error gets assigned to the known attribute instead of the base object.
|
Job 100.4 (rvm: rbx-19mode) errored due to a timeout: |
|
+1 |
* master: Updating changelog. Adding `lib/activeresource.rb` to the project.
guilleiguaran
added a commit
that referenced
this pull request
Jan 31, 2014
…own-attributes Fix Errors#from_type use known_attributes
guilleiguaran
added a commit
that referenced
this pull request
Nov 30, 2015
…own-attributes Fix Errors#from_type use known_attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the use of #attributes.keys with #known_attributes
in Errors#from_array and Errors#from_hash. This is done so that when
ActiveResource grabs errors for attributes defined in the schema, but
don't yet exist as an attribute on the object, the error gets assigned
to the known attribute instead of the base object.