Merge pull request #489 from kamipo/remove_unused_bind_values

Remove unused `bind_values`
rails · Jul 25, 2017 · 0e7ce3f · 0e7ce3f
2 parents bfb770d + e6b707f
commit 0e7ce3f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/lib/arel/tree_manager.rb b/lib/arel/tree_manager.rb
@@ -7,11 +7,8 @@ class TreeManager
 
     attr_reader :ast
 
-    attr_accessor :bind_values
-
     def initialize
-      @ctx    = nil
-      @bind_values = []
+      @ctx = nil
     end
 
     def to_dot

diff --git a/test/test_select_manager.rb b/test/test_select_manager.rb
@@ -10,13 +10,6 @@ def test_join_sources
       assert_equal "SELECT FROM 'foo'", manager.to_sql
     end
 
-    def test_manager_stores_bind_values
-      manager = Arel::SelectManager.new
-      assert_equal [], manager.bind_values
-      manager.bind_values = [1]
-      assert_equal [1], manager.bind_values
-    end
-
     describe 'backwards compatibility' do
       describe 'project' do
         it 'accepts symbols as sql literals' do