Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Raise ArgumentError if limit and lock are used for Oracle12 visitor #430
it would generates
ORA-02014: cannot select FOR UPDATE from view with DISTINCT, GROUP BY, etc.
Oracle12 visitor is a new feature for Rails 5, then it would not cause large incompatibility for users.
This was referenced
May 2, 2016
Thank for merging.
To support Rails 5, Oracle enhanced adapter requires these two commits backported to the next version of arel which should be tagged
commit c938736cf3b6cceb85a353e0c9f53ac9d842f742 Author: Yasuo Honda <email@example.com> Date: Mon May 2 13:31:06 2016 +0000 Raise ArgumentError if limit and lock are used for Oracle12 visitor it would generates `SELECT ... FETCH FIRST n ROWS ONLY FOR UPDATE` which causes Oracle 12c database returns this error : ORA-02014: cannot select FOR UPDATE from view with DISTINCT, GROUP BY, etc. commit 6f54a359e68395c9ea1506d38a2bf156ba7946ad Author: Yasuo Honda <firstname.lastname@example.org> Date: Tue Apr 5 20:48:48 2016 +0000 Support Oracle bind parameter value for Oracle12 visitor
It would be appreciated to release next version of arel 7.0.x including these 2 commits.
It actually changes some behavior for Oracle12 visitor users. There is no Oracle enhanced adapter version released for Rails 5, this behavior change should be fine.