Raise ArgumentError if limit and lock are used for Oracle12 visitor

[yahonda]

Considering several comments in rails/rails#24779 and #337 this pull request changes Oracle12 visitor behavior to return ArgumentError if limit and lock are used.

it would generates SELECT ... FETCH FIRST n ROWS ONLY FOR UPDATE
which causes Oracle 12c database returns this error :

ORA-02014: cannot select FOR UPDATE from view with DISTINCT, GROUP BY, etc.

Oracle12 visitor is a new feature for Rails 5, then it would not cause large incompatibility for users.

[rails-bot]

r? @tenderlove

(@rails-bot has picked a reviewer for you, use r? to override)

[yahonda]

Thank for merging.

To support Rails 5, Oracle enhanced adapter requires these two commits backported to the next version of arel which should be tagged v7.0.1.

• Support Oracle bind parameter value for Oracle12 visitor
• Raise ArgumentError if limit and lock are used for Oracle12 visitor

commit c938736cf3b6cceb85a353e0c9f53ac9d842f742
Author: Yasuo Honda <yasuo.honda@gmail.com>
Date:   Mon May 2 13:31:06 2016 +0000

    Raise ArgumentError if limit and lock are used for Oracle12 visitor
    it would generates `SELECT ... FETCH FIRST n ROWS ONLY FOR UPDATE`
    which causes Oracle 12c database returns this error :

    ORA-02014: cannot select FOR UPDATE from view with DISTINCT, GROUP BY, etc.

commit 6f54a359e68395c9ea1506d38a2bf156ba7946ad
Author: Yasuo Honda <yasuo.honda@gmail.com>
Date:   Tue Apr 5 20:48:48 2016 +0000

    Support Oracle bind parameter value for Oracle12 visitor

It would be appreciated to release next version of arel 7.0.x including these 2 commits.

It actually changes some behavior for Oracle12 visitor users. There is no Oracle enhanced adapter version released for Rails 5, this behavior change should be fine.

[yahonda]

cc: @rafaelfranca This is what I had requested in RailsConf.

[rafaelfranca]

👍, on it.

[yahonda]

@rafaelfranca Hi, Oracle enhanced adapter 17.0.beta1 has been released to support Rails 5. I would like newer version of Arel which should be called 7.0.1 including #422 and #430.

[rafaelfranca]

I'll release 7.1.0, is it fine to you?

[yahonda]

As long as Rails 5.0.x 5-0-stable branch is supported I am fine Are version is 7.1.0.

[rafaelfranca]

Yeah, it is supported.

[rafaelfranca]

7.1.0 released

[akostadinov]

Any reason why same approach as the Oracle old visitor is not used instead of just raising an error? I checked that converting this to ROWNUM worked. Otherwise locking a record seems impossible. See rsim/oracle-enhanced#2237