-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanilla UJS #447
Comments
Thank you so much for the issue but we don't take feature request on the issue tracker. We recommend you to ask in Rails Core mailing list for feedback. |
Just in case someone is interested in it. Current gem code has two possible issues about old browsers. FormData and querySelector. http://caniuse.com/#feat=xhr2 |
@rafaelfranca Really sorry about this, I forgot about the mailing list, no excuse, thanks for your time. @Ximik Thanks for passing by! Do you think you can fix the document.create typo, add a Browser support section to your Readme, bump a 1.0.0 gem version and announce it on http://www.rubyflow.com? That would be terrific. 👍 |
@bbenezech In my repo everything should be fixed and updated to current Rails version (so it should support all features). Please test the gem in your project if you can. The only issue about my the gem is it hasn't tests. I thought about copying them from original Rails code, however they are hardcoded to jquery. However this guy @kirushik was interested in creating the tests. Don't know if he had time for it. Anyway, i'll try to recheck everything and post it before the end of the month. |
@Ximik Check https://github.com/Ximik/vanilla-ujs/blob/master/vendor/assets/javascripts/src/csrf.js#L13 |
@Ximik I've checked — and it would be simpler (at least for me) just to implement a complete new set of tests, not to backport existing ones from either hauleth/vanilla-ujs or rails/jquery-ujs. I'd like to do that (no end-date promised, though) — if the work is actually needed. |
@kirushik I haven't. Is it needed? |
@bbenezech It looks like this issue hasn't been even considered because it originates from the Github, not from the mailing list (see the issue-closing message from @rafaelfranca). |
@bbenezech I've done the stuff you said it's good to be done. I'm not really great about understanding how rails community works, but probably i have to write also in mailing list (or it can be done but u, don't know). The problem is i didn't hear any feedback. Like "we need this" or "we don't give a fuck". It's kinda surprising for me. |
@kirushik I am not sure anyone on Rails Core would be interested in this problematic. They might dismiss it as premature and unnecessary, which makes sense from a maintenance point of vue. @Ximik Good job. I guess the lack of feedback comes from the absence of anything 'new and exiting'. Developers will consider using it when starting a new project and realizing they don't need jQuery anymore. Having a reference 1.0 maintained implementation may be all it needs to get the train started! Thanks a lot for doing it. I'll use it and PR any issue I may find. Please feel free to continue the discussion there: https://github.com/Ximik/vanilla-ujs/issues |
According to http://caniuse.com/, IE<11 is going soon below 3% of the user base.
According to Twitter, 95% (maybe more, not sure) of new apps are written with a React front-end, that doesn't 'invite' for a jQuery dep.
Doesn't it feel like the right timing to start getting rid of the jQuery dependency?
@JangoSteve does what you say 1 year ago (https://www.reddit.com/r/rails/comments/2fzk5z/what_does_rails_use_jquery_for_it_is_possible_to/ckeduvo) still apply? Can we have 2 versions, jquery and vanilla with limited browser support, leaving side by side for a while?
Someone (@hauleth) gave it a go, https://github.com/hauleth/vanilla-ujs, I tried it.
It looks like it work (I found a typo
document.create
instead ofdocument.createElement
but other than that, my app is behaving fine)Problem is, it is hard to find (no announcement in the Ruby community) no browser support details and it looks unmaintained.
Does someone with a solid JS background (ie not me) can review the code and tell us what can be expected in terms of browser support and maintenance overhead if it was to be officially supported?
Does @hauleth or maybe @Ximik (who did a gem out of it) want to talk about it?
Sorry if I'm just polluting, I'm just surprised that there still is no solid solution to get the UJS features I love without a 30k (2.X.X minified&gziped https://mathiasbynens.be/demo/jquery-size) wrapper around
querySelectorAll
orcreateElement
for browsers I probably don't care about any longer.The text was updated successfully, but these errors were encountered: