Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comparison_with_webpacker.md #79

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Update comparison_with_webpacker.md #79

merged 1 commit into from
Mar 10, 2022

Conversation

justin808
Copy link
Contributor

Address feedback in #78

This was referenced Feb 1, 2022
Closed
Open
@justin808
Copy link
Contributor Author

@dhh can you let me know if this helps or if you'd like some changes here.

@justin808 justin808 mentioned this pull request Feb 7, 2022
Closed
@justin808
Copy link
Contributor Author

Any chance of getting a review?

@justin808
Copy link
Contributor Author

Can I get a review?

@hachi8833
Copy link

I've been waiting for the merging 🙏

@justin808
Copy link
Contributor Author

justin808 commented Feb 24, 2022 •
edited
Loading

Hi @rafaelfranca and @dhh, is there anything that you'd like changed?

@dhh dhh merged commit fa1ed8a into rails:main Mar 10, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justin808 @hachi8833 @dhh